Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(objectarium): derive default hash algorithm #301

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

ErikssonJoakim
Copy link
Collaborator

Derives default hash algorithm value in objectarium state rather than to implement the default function. This makes the implementation less verbose and also appeases our linter 🙂 See action error message: https://github.com/okp4/contracts/actions/runs/5736567463/job/15546422078?pr=296

@ErikssonJoakim ErikssonJoakim added the rust Pull requests that update Rust code label Aug 2, 2023
@ErikssonJoakim ErikssonJoakim self-assigned this Aug 2, 2023
@bot-anik
Copy link
Member

bot-anik commented Aug 2, 2023

size-limit report 📦

Path Size
target/wasm32-unknown-unknown/release/okp4_objectarium.wasm 399.85 KB (0%)
target/wasm32-unknown-unknown/release/okp4_law_stone.wasm 634.46 KB (0%)
target/wasm32-unknown-unknown/release/okp4_cognitarium.wasm 757.15 KB (0%)

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #301 (1f3b98c) into main (8cde60e) will increase coverage by 0.03%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   97.99%   98.02%   +0.03%     
==========================================
  Files          41       41              
  Lines        8723     8720       -3     
==========================================
  Hits         8548     8548              
+ Misses        175      172       -3     
Files Changed Coverage Δ
contracts/okp4-objectarium/src/state.rs 100.00% <100.00%> (+1.91%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ErikssonJoakim ErikssonJoakim marked this pull request as ready for review August 2, 2023 09:06
Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good!

@ErikssonJoakim ErikssonJoakim merged commit 27e61d6 into main Aug 2, 2023
18 checks passed
@ErikssonJoakim ErikssonJoakim deleted the refactor/derive-default-hash-algorithm branch August 2, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants