-
-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequence parallelism #2412
Open
djsaunde
wants to merge
30
commits into
main
Choose a base branch
from
sequence-parallelism
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sequence parallelism #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglian
reviewed
Mar 14, 2025
@@ -548,6 +553,14 @@ def apply_patches(self) -> None: | |||
|
|||
patch_self_attn_lora(self.cfg) | |||
|
|||
if self.cfg.sequence_parallel_degree > 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if self.cfg.sequence_parallel_degree > 1: | |
if self.cfg.sequence_parallel_degree and self.cfg.sequence_parallel_degree > 1: |
should fix the NoneType comparison exception in the e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements sequence parallelism via
ring-flash-attn
. Specifically, their hf_adapter.py module is used to patch transformers flash attention withllama3_flash_attn_varlen_func
, the SP implementation from the llama3 tech report. This technically isn't ring attention, but is the most performant SP variant in most cases.I think since the batch API (non-sample packing case) is a special case of the varlen API (sample packing case), these changes should be sufficient to cover both cases, but this should be validated with tests.
Motivation and Context
SP is necessary for long context post-training where the VRAM on a single card results in OOM for a single sequence. If a user has >1 GPUs, they can run longer context post-training by enabling this option.
The attention is distributed across the GPUs according to the set
sequence_parallel_degree
(i.e., ifsequence_parallel_degree = 4
, then sequences are split into 4 equal-length chunks). Attention is computed on each of the sub-sequences, and then comm is done inter-GPU in order to complete the attention computation.How has this been tested?
pytest
coverage (not super comprehensive) and functional tests.Screenshots (if appropriate)
Types of changes
ring-flash-attn
hf_adapter.py
integrationAxolotlTrainer
sampler, dataloader changesDistributedSampler
for SP caseDistributedSampler
random_init
flag to load model without pretrained weights