Feat: Add support for gemma3 and add e2e for gemma2 #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ liger-kernel==0.5.3 | |||
| packaging==23.2 | |||
|
|
|||
| peft==0.14.0 | |||
| transformers==4.49.0 | |||
| transformers @ git+https://github.com/huggingface/transformers@v4.49.0-Gemma-3 | |||
There was a problem hiding this comment.
should we point to main if support for Gemma3 has landed?
There was a problem hiding this comment.
They recommended this branch. We can also point to main 50d3530aa04e7a7d003e6b255a98f79fd0447357. I just set this initially to see how E2E fairs first.
|
We may want to add validation that this doesn't work with liger atm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires transformers tag https://github.com/huggingface/transformers/tree/v4.49.0-Gemma-3
Upstream PR has just been merged: huggingface/transformers#36658
Motivation and Context
How has this been tested?
No, waiting on E2E to verify
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)