fix(test): replace jackfram llama with smollm #2370
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to add and remove |
winglian
reviewed
Feb 28, 2025
| "sequence_len": 1024, | ||
| "load_in_8bit": True, | ||
| "adapter": "lora", | ||
| "lora_r": 8, | ||
| "lora_alpha": 16, | ||
| "lora_dropout": 0.05, | ||
| "lora_target_linear": True, | ||
| "lora_modules_to_save": ["lm_head", "embed_tokens"], |
There was a problem hiding this comment.
this isn't needed if you correct the pad_token. I'm not a fan of changing the test case for a model swap, but rather we should add a new test case to include lora_modules_to_save. otherwise we risk having regressions down the road
There was a problem hiding this comment.
should also remove the unk_token, bos_tokenm, and eos_token from the configs where you swap this. Would also not swap in an instruct model since the original model you're replacing isn't an instruct model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the old jackfram llama 68m with the smollm 135m due to breaking tests.
CI broken: https://github.com/axolotl-ai-cloud/axolotl/actions/runs/13533778077
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)