-
-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry (opt-in version) #2366
Open
djsaunde
wants to merge
30
commits into
main
Choose a base branch
from
telemetry-opt-in
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglian
reviewed
Feb 27, 2025
winglian
reviewed
Feb 27, 2025
winglian
reviewed
Feb 27, 2025
winglian
reviewed
Feb 27, 2025
winglian
reviewed
Feb 27, 2025
winglian
approved these changes
Mar 5, 2025
…/ end, error tracking
8df8433
to
7f7e566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying from #2359 with minor changes for opt-in telemetry:
Description
Telemetry for Axolotl. Implementation of system described in #2323.
Features the following:
axolotl.telemetry.manager
:TelemetryManager
class that interacts with the PostHog Python SDK and sends telemetry. Handles opt-in (viaDO_NOT_TRACK
orAXOLOTL_DO_NOT_TRACK
env vars), organization whitelisting (allbase_model
s except for those that are whitelisted are redacted), and path sanitization (_path
or_dir
config (key, value) pairs are redacted).axolotl.telemetry.errors
: Function decorator implementation for tracking errors in various important methods in the codebase (preprocess
,train
,evaluate
,inference
, etc.). Includes path sanitization to remove local paths, but keeps axolotl paths / other Python library paths for debugging purposes.axolotl.telemetry.runtime_metrics
: Dataclass for metrics tracked during model training, including timing metrics, memory metrics, and elapsed steps / epochs.axolotl.telemetry.callbacks
: Includes callback for trainer to send telemetry related to the aforementioned runtime metrics class.Motivation and Context
See #2323.
How has this been tested?
Pytest tests for each added module + some manual testing and viewing of telemetry in PostHog console.