[KD] add uld and jsd #2253
Open
[KD] add uld and jsd #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglian
force-pushed
the
kd-trainer
branch
2 times, most recently
from
2dcbc0d to
35a84f2
Compare
winglian
reviewed
Feb 6, 2025
Comment on lines
+60
to
+70
| # Get masked student probabilities | ||
| student_probs_masked = student_probs[valid_mask] | ||
|
|
||
| # Get masked teacher probabilities | ||
| teacher_probs_masked = teacher_probs[valid_mask] | ||
|
|
||
| # Sort student probabilities in descending order | ||
| student_probs_sorted, _ = torch.sort(student_probs_masked, dim=-1, descending=True) | ||
|
|
||
| # For teacher probs, we already have top-K, so just ensure they're sorted | ||
| teacher_probs_sorted, _ = torch.sort(teacher_probs_masked, dim=-1, descending=True) |
There was a problem hiding this comment.
@kashif since the token_ids don't match, would it be better to sort, then. just take top_k of the student distribution?
There was a problem hiding this comment.
so let me check with the definition of wasserstein loss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ULD loss and JSD KD Loss
Paper
https://arxiv.org/abs/2402.12030