Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Trait for Circuit with Default Inputs #223

Merged
merged 3 commits into from
Nov 28, 2023
Merged

[feat] Trait for Circuit with Default Inputs #223

merged 3 commits into from
Nov 28, 2023

Conversation

nyunyunyunyu
Copy link
Contributor

  • Add CircuitWithDefault trait which can return a circuit instance with default inputs for given params.

jonathanpwang
jonathanpwang approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Side note: this is kind of the original purpose of the Circuit::without_witnesses function, but that only takes &self because the Circuit::Params field only came later.

@jonathanpwang jonathanpwang merged commit b28429e into develop Nov 28, 2023
2 checks passed
@jonathanpwang jonathanpwang deleted the feat/dummy-circuit branch November 28, 2023 22:51
jonathanpwang added a commit that referenced this pull request Nov 30, 2023
@jonathanpwang
[feat] Trait for Circuit with Default Inputs (#223)
d92ecfc 
* Add a trait for Circuit with default inputs

* Fix lint

* Remove witness_gen_only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyunyunyunyu @jonathanpwang