Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.4.1 #214

Closed
wants to merge 33 commits into from
Closed

Release v0.4.1 #214

wants to merge 33 commits into from

Conversation

jonathanpwang
Copy link
Contributor

No description provided.

jonathanpwang and others added 30 commits September 18, 2023 08:30
Fix multiple phase lookup
chore: add conversion `SafePrimitive` to `QuantumCell::Existing`
It's convenient to be able to construct the structs from vectors of safe
bytes externally. Only unsafe-ness is `len <= max_len` is not checked.
chore: derive `Hash` for `BaseCircuitParams`
chore: impl `AsRef, AsMut` for `BaseCircuitBuilder` to self
chore: impl `AsRef, AsMut` for `BaseConfig` to self
* chore: add getters to `KeccakComponentShardCircuit`

For example, it's useful to access `BaseCircuitBuilder` to read public instances.

* chore: `inputs` getter for `KeccakComponentShardCircuit`

* feat: remove getter for `BaseCircuitBuilder`

`BaseCircuitBuilder` is built during `synthesize` after raw vanilla
circuit synthesis, so it should not be accessed externally.
Expose Keccak format_input
* feat: basic dynamic lookup table gadget

* chore: fix imports
chore: expose `spec` in `PoseidonHasher`
chore: fix halo2-pse build error
…te usage (#195)

* feat: expose `load_keccak_assigned_rows` for external crates to use

* feat: split `encode_inputs_from_keccak_fs` into

`pack_inputs_from_keccak_fs` and poseidon hashing part.
The packing part can be used separately from the Poseidon-specific part.

* chore: rename function
chore: add getters to `PoseidonCompactChunkInput`
* chore: fix deref from get_copy

* chore: add missing docs from getters
* chore: import `snark-verifier-sdk`

* feat: implement `CircuitExt` for `KeccakComponentShardCircuit`

so it can be aggregated by `snark-verifier-sdk`

* chore: derive `Serialize` for keccak circuit params
…t lookup poison (#206)

* fix: add fixed column to `BasicDynLookupConfig`

To prevent looking up into poisoned rows of `table`.

* feat: change `memory` example to use `BasicDynLookupConfig` for testing

* feat: change `BasicDynLookupConfig` to support zero key

* chore: move helper functions to `utils::halo2`
* chore: add crate prefix to `type_id`s

* fix: module_path! url

* chore: add type_id warning to `Context::new` and `ContextCell::new`
…_raw` (#224)

* fix: `BasicDynLookupConfig::assign_virtual_table_to_raw`

* feat: add safety check on all assigned_advice HashMap insertions
)

chore: make keccak `inputs` `RefCell`
@jonathanpwang jonathanpwang deleted the branch release-0.4.0-rc December 10, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants