Skip to content

Commit

Permalink
docs: fix grammar mistake in version representation (#295)
Browse files Browse the repository at this point in the history
  • Loading branch information
lipperhey authored Feb 22, 2025
1 parent af9ef30 commit dd04ade
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hashes/zkevm/src/sha256/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

SHA-256 circuit in vanilla halo2. This implementation is largely based on [Brechtpd](https://github.com/Brechtpd)'s [PR](https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/756) to the PSE `zkevm-circuits`. His implementation of SHA-256 is in turn based on his implementation of Keccak using the "Bits" approach: one can read more about it [here](https://hackmd.io/NaTuIvmaQCybaOYgd-DG1Q?view#Bit-implementation).

The major difference is that this version directly represent raw inputs and SHA-256 digests as witnesses, while the original version only has RLCs (random linear combination) of raw inputs and outputs. Because this version doesn't need RLCs, it doesn't have the 2nd phase or use challenge APIs.
The major difference is that this version directly represents raw inputs and SHA-256 digests as witnesses, while the original version only has RLCs (random linear combination) of raw inputs and outputs. Because this version doesn't need RLCs, it doesn't have the 2nd phase or use challenge APIs.

### Logical Input/Output

Expand Down

0 comments on commit dd04ade

Please sign in to comment.