chaincmd: correctly create consortium engine in import chain #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minh-bq
force-pushed
the
fix/import-chain-consensus
branch
from
2c0e312
to
9a30eea
Compare
Currently, when import chain is used, we don't recognize the chain config to create the consortium engine. This commit creates the consortium engine when it is set in the chain config.
In version 1, the checkpoint header check happens early in the header verification step. This makes statedb read sometimes happens in incorrect statedb. While full sync, this leads to peer drop but still be able to continue syncing with other peers. However, while running import chain command or fast sync, this could lead to error. Add a option to disable checkpoint header check in these cases.
minh-bq
force-pushed
the
fix/import-chain-consensus
branch
from
9a30eea
to
edb1059
Compare
huyngopt1994
approved these changes
May 21, 2024
Francesco4203
pushed a commit
to Francesco4203/ronin
that referenced
this pull request
Jun 18, 2024
…inity#371) * consortium: remove unused genesis in consensus engine * chaincmd: correctly create consortium engine in import chain Currently, when import chain is used, we don't recognize the chain config to create the consortium engine. This commit creates the consortium engine when it is set in the chain config. * consortium-v1: add an option to disable checkpoint header check In version 1, the checkpoint header check happens early in the header verification step. This makes statedb read sometimes happens in incorrect statedb. While full sync, this leads to peer drop but still be able to continue syncing with other peers. However, while running import chain command or fast sync, this could lead to error. Add a option to disable checkpoint header check in these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when import chain is used, we don't recognize the chain config to
create the consortium engine. This commit creates the consortium engine when it
is set in the chain config.