p2p/server: add DNS resolved candidates to distributed hash table #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minh-bq
force-pushed
the
feat/add-dns-to-dht
branch
6 times, most recently
from
21556df
to
9fb7dda
Compare
Currently, DNS resolved candidates of eth protocol are added as candidates for dialing but not added to DHT. The DHT's seed nodes are still configured via hardcoded nodes in bootnodes flag. As we want to replace the hardcoded bootnodes entirely with DNS resolved nodes, we resolve some nodes from the DNS discovery URL and put them into DHT when setting up the p2p discovery.
minh-bq
force-pushed
the
feat/add-dns-to-dht
branch
from
9fb7dda
to
a018098
Compare
huyngopt1994
approved these changes
Apr 4, 2024
Francesco4203
pushed a commit
to Francesco4203/ronin
that referenced
this pull request
Jun 18, 2024
…ieinfinity#370) Currently, DNS resolved candidates of eth protocol are added as candidates for dialing but not added to DHT. The DHT's seed nodes are still configured via hardcoded nodes in bootnodes flag. As we want to replace the hardcoded bootnodes entirely with DNS resolved nodes, we resolve some nodes from the DNS discovery URL and put them into DHT when setting up the p2p discovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, DNS resolved candidates of eth protocol are added as candidates for dialing but not added to DHT. The DHT's seed nodes are still configured via hardcoded nodes in bootnodes flag. As we want to replace the hardcoded bootnodes entirely with DNS resolved nodes, we resolve some nodes from the DNS discovery URL and put them into DHT when setting up the p2p discovery.