Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchain: add the finalized block number and block hash to chain event #357

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

minh-bq
Copy link
Contributor

@minh-bq minh-bq commented Sep 27, 2023

This commit adds the finalized block number and block hash to chain event in writeBlockWithState. It also adds the additionalchainevent.enable flag and moves all blockchain's functionality related to subscriber under this flag.

@minh-bq minh-bq force-pushed the feat/finalized-chain-event branch 2 times, most recently from 2a145fb to 269ccc1 Compare September 27, 2023 07:22
This commit adds the finalized block number and block hash to chain event in
writeBlockWithState. It also adds the additionalchainevent.enable flag and moves
all blockchain's functionality related to subscriber under this flag.
Copy link
Contributor

@DNK90 DNK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minh-bq minh-bq merged commit b763c66 into axieinfinity:master Sep 27, 2023
1 check passed
@minh-bq minh-bq deleted the feat/finalized-chain-event branch September 27, 2023 09:41
andicrypt pushed a commit to andicrypt/ronin that referenced this pull request Nov 1, 2023
…ent (axieinfinity#357)

This commit adds the finalized block number and block hash to chain event in
writeBlockWithState. It also adds the additionalchainevent.enable flag and moves
all blockchain's functionality related to subscriber under this flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants