monitor/finality: add flag to enable finality vote monitor (#358)

* monitor/finality: add flag to enable finality vote monitor

This commit adds monitor.finalityvote flag to enable finality vote monitor.

* Dockerfile: set ENABLE_FAST_FINALITY_SIGN default to be false

In common case, non-validator nodes doesn't need to enable fast finality sign so
we make this environment variable default to be false.

Dockerfile

@@ -24,7 +24,7 @@ ENV FORCE_INIT 'true'
 ENV RONIN_PARAMS ''
 ENV INIT_FORCE_OVERRIDE_CHAIN_CONFIG 'false'
 ENV ENABLE_FAST_FINALITY 'true'
-ENV ENABLE_FAST_FINALITY_SIGN 'true'
+ENV ENABLE_FAST_FINALITY_SIGN 'false'
 ENV BLS_PRIVATE_KEY ''
 ENV BLS_PASSWORD ''
 ENV BLS_AUTO_GENERATE 'false'

cmd/ronin/main.go

@@ -166,6 +166,7 @@ var (
 		configFileFlag,
 		utils.CatalystFlag,
 		utils.MonitorDoubleSign,
+		utils.MonitorFinalityVoteFlag,
 		utils.StoreInternalTransactions,
 		utils.MaxCurVoteAmountPerBlock,
 		utils.EnableFastFinality,

cmd/ronin/usage.go

@@ -56,6 +56,7 @@ var AppHelpFlagGroups = []flags.FlagGroup{
 			utils.WhitelistFlag,
 			utils.ForceOverrideChainConfigFlag,
 			utils.MonitorDoubleSign,
+			utils.MonitorFinalityVoteFlag,
 			utils.StoreInternalTransactions,
 			utils.DisableRoninProtocol,
 			utils.AdditionalChainEventFlag,

cmd/utils/flags.go

@@ -235,6 +235,10 @@ var (
 		Name:  "monitor.doublesign",
 		Usage: "Enable double sign monitoring",
 	}
+	MonitorFinalityVoteFlag = cli.BoolFlag{
+		Name:  "monitor.finalityvote",
+		Usage: "Enable finality vote monitoring",
+	}
 	StoreInternalTransactions = cli.BoolFlag{
 		Name:  "internaltxs",
 		Usage: "Enable storing internal transactions to db",
@@ -1840,6 +1844,10 @@ func SetEthConfig(ctx *cli.Context, stack *node.Node, cfg *ethconfig.Config) {
 	if ctx.GlobalBool(AdditionalChainEventFlag.Name) {
 		cfg.EnableAdditionalChainEvent = true
 	}
+
+	if ctx.GlobalBool(MonitorFinalityVoteFlag.Name) {
+		cfg.EnableMonitorDoubleSign = true
+	}
 }
 
 // SetDNSDiscoveryDefaults configures DNS discovery with the given URL if

eth/backend.go

@@ -208,6 +208,9 @@ func New(stack *node.Node, config *ethconfig.Config) (*Ethereum, error) {
 	if config.EnableAdditionalChainEvent {
 		eth.blockchain.EnableAdditionalChainEvent()
 	}
+	if config.EnableMonitorFinalityVote {
+		go eth.blockchain.StartFinalityVoteMonitor()
+	}
 
 	// Rewind the chain in case of an incompatible config upgrade.
 	if compat, ok := genesisErr.(*params.ConfigCompatError); ok {

eth/ethconfig/config.go

@@ -213,6 +213,9 @@ type Config struct {
 	// Enable double sign monitoring
 	EnableMonitorDoubleSign bool
 
+	// Enable finality vote monitoring
+	EnableMonitorFinalityVote bool
+
 	// Disable ronin p2p protocol
 	DisableRoninProtocol bool