triedb/pathdb: fix panic in recoverable (#29107)

* triedb/pathdb: fix panic in recoverable

* triedb/pathdb: add todo

* triedb/pathdb: rename

* triedb/pathdb: rename

core/rawdb/schema_test.go

@@ -99,7 +99,7 @@ func TestResolveAccountTrieNodeKey(t *testing.T) {
 		},
 		{
 			name:          "storage prefixed",
-			inputKey:      append(trieNodeStoragePrefix, bytes4...),
+			inputKey:      append(TrieNodeStoragePrefix, bytes4...),
 			expectedCheck: false,
 			expectedKey:   nil,
 		},
@@ -175,7 +175,7 @@ func TestResolveStorageTrieNode(t *testing.T) {
 		},
 		{
 			name:          "storage prefixed hash 20 length 4",
-			inputKey:      append(append(trieNodeStoragePrefix, bytes20...), bytes4...),
+			inputKey:      append(append(TrieNodeStoragePrefix, bytes20...), bytes4...),
 			expectedCheck: false,
 			expectedHash:  common.Hash{},
 			expectedKey:   nil,

trie/triedb/pathdb/database.go

@@ -397,18 +397,23 @@ func (db *Database) Recoverable(root common.Hash) bool {
 	if *id >= dl.stateID() {
 		return false
 	}
-
+	// This is a temporary workaround for the unavailability of the freezer in
+	// dev mode. As a consequence, the Pathdb loses the ability for deep reorg
+	// in certain cases.
+	// TODO(rjl493456442): Implement the in-memory ancient store.
+	if db.freezer == nil {
+		return false
+	}
 	// Ensure the requested state is a canonical state and all state
 	// histories in range [id+1, disklayer.ID] are present and complete.
-	parent := root
 	return checkHistories(db.freezer, *id+1, dl.stateID()-*id, func(m *meta) error {
-		if m.parent != parent {
+		if m.parent != root {
 			return errors.New("unexpected state history")
 		}
 		if len(m.incomplete) > 0 {
 			return errors.New("incomplete state history")
 		}
-		parent = m.root
+		root = m.root
 		return nil
 	}) == nil
 }