Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

feat: add GitHub Actions for Vale #245

Merged
merged 6 commits into from
Nov 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,31 @@ bridge
bridge operator
bridge operator node
delegator
EVM
full node
Governing Validator
Katana
mainnet
NFT
node
node operator
non-validator node
OIDC
OpenID Connect
RON
RON Staking
Ronin
Ronin Block Explorer
Ronin Bridge
Ronin CLI
Ronin mainnet
Ronin Name Service
Ronin Wallet
RNS
Saigon testnet
Standard Validator
testnet
UTC
validator
Validator Candidate
Validator Dashboard
Expand Down
16 changes: 16 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Editorial review
on: [pull_request]

jobs:
vale:
name: runner / vale
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: errata-ai/vale-action@reviewdog
with:
files: docs
fail_on_error: true
env:
# Required
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
5 changes: 3 additions & 2 deletions .vale.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Relative path to the style directory
StylesPath = utils/vale/styles
StylesPath = .github/styles

# Name of the vocabulary directory
Vocab = Ronin
Expand All @@ -19,7 +19,8 @@ WordTemplate = \b(?:%s)\b
[formats]
mdx = md

[*]
[*.{md,txt}]

BasedOnStyles = Google

Google.FirstPerson = NO
Expand Down
26 changes: 13 additions & 13 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
### Next steps

After you address feedback from maintainers, your PR will be merged and your contributions will be visible on [docs.roninchain.com](https://docs.roninchain.com).
Congratulations, you're a full-blown contributor!
Congratulations, you're a full-blown contributor.

### Naming conventions

Expand All @@ -153,7 +153,7 @@

* Don't capitalize the first letter, reserve that for proper nouns (product
names, for example).
* Use the imperative, present tense: "change" not "changed" nor "changes".
* Use the imperative, present tense: "change" not "changed" nor "changes."
* Don't add a period (.) at the end.

## Run locally
Expand Down Expand Up @@ -405,7 +405,7 @@

An explanation topic works well when:

* It answers questions "What is this?", "Why should I use it?", "How does it
* It answers questions "What is this?," "Why should I use it?," "How does it

Check notice on line 408 in docs/CONTRIBUTING.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/CONTRIBUTING.md#L408

[Google.Contractions] Feel free to use 'what's' instead of 'What is'.
Raw output
{"message": "[Google.Contractions] Feel free to use 'what's' instead of 'What is'.", "location": {"path": "docs/CONTRIBUTING.md", "range": {"start": {"line": 408, "column": 25}}}, "severity": "INFO"}
work?"
* It gives context to a subject or topic that your readers might not have.
* It provides essential facts, background, and diagrams to help your readers
Expand All @@ -424,8 +424,8 @@

###### About title metadata in explanation topics

To write a title for an explanation topic, use "About + noun" or "About + noun phrase", where to describe
the subject. For example: "About events", "About data quality."
To write a title for an explanation topic, use "About + noun" or "About + noun phrase," where to describe
the subject. For example: "About events," "About data quality."

###### About the "Overview" section in explanations

Expand Down Expand Up @@ -483,8 +483,8 @@
###### About title metadata in how-to guides

To write a title for a how-to guide, start with a verb.
For example, "Get started", "Integrate with Ronin VRF", "Authenticate users
with OIDC and Sky Mavis Account". The outcome of the task should be clear
For example, "Get started," "Integrate with Ronin VRF," "Authenticate users

Check notice on line 486 in docs/CONTRIBUTING.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/CONTRIBUTING.md#L486

[Google.Acronyms] Spell out 'VRF', if it's unfamiliar to the audience.
Raw output
{"message": "[Google.Acronyms] Spell out 'VRF', if it's unfamiliar to the audience.", "location": {"path": "docs/CONTRIBUTING.md", "range": {"start": {"line": 486, "column": 51}}}, "severity": "INFO"}
with OIDC and Sky Mavis Account." The outcome of the task should be clear
to the user from the title alone.

###### About the "Overview" section in how-to guides
Expand All @@ -496,7 +496,7 @@

Explain what knowledge the user needs to have, or what configuration they must
complete, before starting the task. Use imperative sentences, for example, "Read
the explanation topic" or "Download and install the app".
the explanation topic" or "Download and install the app."

###### About the "task name" section

Expand Down Expand Up @@ -555,8 +555,8 @@

To write a title for a reference topic, use nouns that clearly describe the
contents of the topic. Make sure that the title is accessible to users who are
just getting started. For example, "Slashing rules", "Network parameters", "User
roles".
just getting started. For example, "Slashing rules," "Network parameters," "User
roles."

###### About the "Overview" section in reference topics

Expand All @@ -569,7 +569,7 @@
are documenting. You might find it helpful to organize the contents using
tables, lists, interactive object-schemas. For example, if you're writing a
reference page for an API endpoint, you might define sections such as "General
requirements", "Request parameters", and "Responses". The format might be
requirements," "Request parameters," and "Responses." The format might be
different for each section—"General requirements" might be a list, while
"Request parameters" and "Responses" are tables.
* Use the "don't repeat yourself" (DRY) method and re-use content if it's
Expand Down Expand Up @@ -682,7 +682,7 @@

Quickstarts enable a user to quickly complete a discrete, focused task by illustrating a workflow with only essential steps, in about five minutes or 600 words. Quickstarts can be used for quickly getting set up with a new tool, or for quickly completing another task. For more complex tasks, use a tutorial.

Quickstarts are useful when someone already understands the feature or product and is ready to try it out. Users of quickstarts are not looking for an explanation and don't need to be convinced to use the product––they just want instructions quickly. Users who don't understand a step are willing to dig deeper in a separate doc.
Quickstarts are useful when someone already understands the feature or product and is ready to try it out. Users of quickstarts are not looking for an explanation and don't need to be convinced to use the product-they just want instructions quickly. Users who don't understand a step are willing to dig deeper in a separate doc.

Check notice on line 685 in docs/CONTRIBUTING.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/CONTRIBUTING.md#L685

[Google.Contractions] Feel free to use 'aren't' instead of 'are not'.
Raw output
{"message": "[Google.Contractions] Feel free to use 'aren't' instead of 'are not'.", "location": {"path": "docs/CONTRIBUTING.md", "range": {"start": {"line": 685, "column": 129}}}, "severity": "INFO"}

Check notice on line 685 in docs/CONTRIBUTING.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/CONTRIBUTING.md#L685

[Google.Passive] In general, use active voice instead of passive voice ('be convinced').
Raw output
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('be convinced').", "location": {"path": "docs/CONTRIBUTING.md", "range": {"start": {"line": 685, "column": 182}}}, "severity": "INFO"}

##### Quickstart template

Expand All @@ -692,7 +692,7 @@

###### About title metadata in quickstarts

* When the guide helps someone get started with a new tool, preface the title with "Quickstart". For example, "Quickstart for Sky Mavis Account."
* When the guide helps someone get started with a new tool, preface the title with "Quickstart." For example, "Quickstart for Sky Mavis Account."
* For other use cases, follow the title guidelines for procedures and omit the word "Quickstart."

###### About the "Overview" section in quickstarts
Expand Down
2 changes: 1 addition & 1 deletion docs/basics/introduction.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ description: What is Ronin?

## What is Ronin?

Ronin is an EVM blockchain specifically forged for gaming. Launched by Sky Mavis, the creator of Web3’s breakout title Axie Infinity which has generated over $1.3B in revenue, Ronin is the only blockchain proven to scale a single game to accommodate millions of daily active users and has processed over $4B in NFT volumes. Ronin optimizes for near-instant transactions and negligible fees that enable millions of in-game transactions to occur seamlessly, making it the leading choice for Web3 games.
Ronin is an EVM blockchain specifically forged for gaming. Launched by Sky Mavis, the creator of Web3’s breakout title Axie Infinity which has generated over $1.3 B in revenue, Ronin is the only blockchain proven to scale a single game to accommodate millions of daily active users and has processed over $4 B in NFT volumes. Ronin optimizes for near-instant transactions and negligible fees that enable millions of in-game transactions to occur seamlessly, making it the leading choice for Web3 games.

## What makes Ronin unique as a blockchain?

Expand Down
2 changes: 1 addition & 1 deletion docs/basics/key-concepts.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

### BLS key

BonehLynnShacham (BLS) is a digital signature method used for verifying the authenticity of digital messages or documents.
Boneh-Lynn-Shacham (BLS) is a digital signature method used for verifying the authenticity of digital messages or documents.

Check notice on line 40 in docs/basics/key-concepts.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/basics/key-concepts.md#L40

[Google.Parens] Use parentheses judiciously.
Raw output
{"message": "[Google.Parens] Use parentheses judiciously.", "location": {"path": "docs/basics/key-concepts.md", "range": {"start": {"line": 40, "column": 20}}}, "severity": "INFO"}

The BLS key is what the validator uses to produce finality votes. Validators who produce finality vote receive a reward. If a validator fails to produce a finality vote, no slashing penalty applies.

Expand Down
6 changes: 3 additions & 3 deletions docs/validators/manage/take-emergency-exit.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

Based on the Governing Validators' vote on your Emergency Exit proposal, your stake may be refunded as follows:

- If the proposal is approved, your entire self-stake is refunded: 50,000 RON is credited immediately, while the remaining amount is transferred to you the next day (00:00 UTC).
- If the proposal is not approved or expires, you're refunded the amount equal to your self-stake minus 50,000 RON. The amount is transferred to you after seven working days from the proposal's creation date.
* If the proposal's approved, your entire self-stake is refunded: 50,000 RON is credited immediately, while the remaining amount is transferred to you the next day (00:00 UTC).

Check notice on line 28 in docs/validators/manage/take-emergency-exit.mdx

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/manage/take-emergency-exit.mdx#L28

[Google.Passive] In general, use active voice instead of passive voice ('is refunded').
Raw output
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('is refunded').", "location": {"path": "docs/validators/manage/take-emergency-exit.mdx", "range": {"start": {"line": 28, "column": 54}}}, "severity": "INFO"}

Check notice on line 28 in docs/validators/manage/take-emergency-exit.mdx

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/manage/take-emergency-exit.mdx#L28

[Google.Passive] In general, use active voice instead of passive voice ('is credited').
Raw output
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('is credited').", "location": {"path": "docs/validators/manage/take-emergency-exit.mdx", "range": {"start": {"line": 28, "column": 78}}}, "severity": "INFO"}

Check notice on line 28 in docs/validators/manage/take-emergency-exit.mdx

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/manage/take-emergency-exit.mdx#L28

[Google.Passive] In general, use active voice instead of passive voice ('is transferred').
Raw output
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('is transferred').", "location": {"path": "docs/validators/manage/take-emergency-exit.mdx", "range": {"start": {"line": 28, "column": 130}}}, "severity": "INFO"}
* If the proposal's not approved or expires, you're refunded the amount equal to your self-stake minus 50,000 RON. The amount is transferred to you after seven working days from the proposal's creation date.

Check notice on line 29 in docs/validators/manage/take-emergency-exit.mdx

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/manage/take-emergency-exit.mdx#L29

[Google.Passive] In general, use active voice instead of passive voice ('is transferred').
Raw output
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('is transferred').", "location": {"path": "docs/validators/manage/take-emergency-exit.mdx", "range": {"start": {"line": 29, "column": 127}}}, "severity": "INFO"}

After your emergency exit is complete, you can no longer validate transactions on Ronin and receive rewards. Your status is set to "Renounced".
After your emergency exit is complete, you can no longer validate transactions on Ronin and receive rewards. Your status is set to "Renounced."

Check notice on line 31 in docs/validators/manage/take-emergency-exit.mdx

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/manage/take-emergency-exit.mdx#L31

[Google.Passive] In general, use active voice instead of passive voice ('is set').
Raw output
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('is set').", "location": {"path": "docs/validators/manage/take-emergency-exit.mdx", "range": {"start": {"line": 31, "column": 122}}}, "severity": "INFO"}
59 changes: 30 additions & 29 deletions docs/validators/setup/generate-keys.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@

Each validator node requires private keys for signing blocks and consensus messages sent to the other validators in the network.

The required private keys include a BLS key and an ECDSA key. The keys are named after digital signature schemes: Elliptic Curve Digital Signature Algorithm (ECDSA) and BonehLynnShacham (BLS), respectively.
The required private keys include a BLS key and an ECDSA key. The keys are named after digital signature schemes, Elliptic Curve Digital Signature Algorithm (ECDSA) and Boneh-Lynn-Shacham (BLS), respectively.

Check notice on line 13 in docs/validators/setup/generate-keys.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/setup/generate-keys.md#L13

[Google.Passive] In general, use active voice instead of passive voice ('are named').
Raw output
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('are named').", "location": {"path": "docs/validators/setup/generate-keys.md", "range": {"start": {"line": 13, "column": 72}}}, "severity": "INFO"}

Check notice on line 13 in docs/validators/setup/generate-keys.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/setup/generate-keys.md#L13

[Google.Parens] Use parentheses judiciously.
Raw output
{"message": "[Google.Parens] Use parentheses judiciously.", "location": {"path": "docs/validators/setup/generate-keys.md", "range": {"start": {"line": 13, "column": 158}}}, "severity": "INFO"}

- The BLS key is used for producing finality votes. Validators who produce finality votes receive a reward.
- The ECDSA key is used for signing blocks.
* The BLS key is used for producing finality votes. Validators who produce finality votes receive a reward.

Check notice on line 15 in docs/validators/setup/generate-keys.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/setup/generate-keys.md#L15

[Google.Passive] In general, use active voice instead of passive voice ('is used').
Raw output
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('is used').", "location": {"path": "docs/validators/setup/generate-keys.md", "range": {"start": {"line": 15, "column": 15}}}, "severity": "INFO"}
* The ECDSA key is used for signing blocks.

Check notice on line 16 in docs/validators/setup/generate-keys.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/setup/generate-keys.md#L16

[Google.Passive] In general, use active voice instead of passive voice ('is used').
Raw output
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('is used').", "location": {"path": "docs/validators/setup/generate-keys.md", "range": {"start": {"line": 16, "column": 17}}}, "severity": "INFO"}

## Generate a BLS key

Expand All @@ -22,37 +22,38 @@
### Generate using the CLI

1. Build Ronin from the source code:
```

```bash
$ git clone https://github.com/axieinfinity/ronin
$ cd ronin
$ make ronin
```

2. Add `./build/bin/ronin` to the `$PATH` environment variable. You can do this by adding the following line to your `$HOME/.profile` or `/etc/profile` (for a system-wide installation):

```
```bash
export PATH=$PATH:/path/to/ronin
```

If run from the `ronin` directory, then the command is as follows:
```

```bash
export PATH=$PATH:./build/bin/ronin
```

**Note:** Make sure to close and reopen the terminal after adding the path.

3. Generate a BLS key pair:

```
```bash
$ mkdir bls_keystore
$ echo "input_your_password" > bls_password
$ ronin account generatebls --secret
```

The output is the following:

```
```bash
Successfully generated BLS key
Public key: {your_public_key}
Secret key: {your_private_key}
Expand All @@ -62,25 +63,25 @@

To reveal the public key, run this command:

```
$ ronin account listbls
```bash
ronin account listbls
```

The output is the following:

```
```bash
BLS public key #0: {your_public_key}
```

To reveal both the public key and private key, run this command:

```bash
ronin account listbls --secret
```
$ ronin account listbls --secret
```


The output is the following:

```
```bash
BLS public key #0: {your_public_key}
BLS secret key #0: {your_private_key}
```
Expand All @@ -101,9 +102,9 @@

## Generate an ECDSA key

You can generate an ECDSA key pair using the Ronin CLI or the Ronin Wallet app or extension.
You can generate an ECDSA key pair using the Ronin command-line tool (CLI) or the Ronin Wallet app or extension.

Check notice on line 105 in docs/validators/setup/generate-keys.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/setup/generate-keys.md#L105

[Google.Parens] Use parentheses judiciously.
Raw output
{"message": "[Google.Parens] Use parentheses judiciously.", "location": {"path": "docs/validators/setup/generate-keys.md", "range": {"start": {"line": 105, "column": 70}}}, "severity": "INFO"}

Check warning on line 105 in docs/validators/setup/generate-keys.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/setup/generate-keys.md#L105

[Google.WordList] Use 'command-line tool' instead of 'CLI'.
Raw output
{"message": "[Google.WordList] Use 'command-line tool' instead of 'CLI'.", "location": {"path": "docs/validators/setup/generate-keys.md", "range": {"start": {"line": 105, "column": 71}}}, "severity": "WARNING"}

### Generate using the CLI
### Generate an ECDSA key using the CLI

Check warning on line 107 in docs/validators/setup/generate-keys.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/setup/generate-keys.md#L107

[Google.WordList] Use 'command-line tool' instead of 'CLI'.
Raw output
{"message": "[Google.WordList] Use 'command-line tool' instead of 'CLI'.", "location": {"path": "docs/validators/setup/generate-keys.md", "range": {"start": {"line": 107, "column": 37}}}, "severity": "WARNING"}

#### Prerequisites

Expand All @@ -114,8 +115,8 @@
#### Steps

1. Compile the `ethkey` tool from the Ronin source code by running the following commands:
```

```bash
$ git clone https://github.com/axieinfinity/ronin
$ cd ronin
$ go get ./...
Expand All @@ -125,20 +126,20 @@

The output is similar to the following:

```
```bash
-rwxr-xr-x 1 user staff 16306850 Mar 23 18:13 ethkey
```

2. Generate the key pair and set a password:

```
$ ./ethkey generate your_private_key_name
```bash
./ethkey generate your_private_key_name
```

3. Reveal the key pair:

```
$ ./ethkey inspect --private your_private_key_name
```bash
./ethkey inspect --private your_private_key_name
```

### Generate using Ronin Wallet
Expand All @@ -147,13 +148,13 @@

#### Browser extension

<img src={extension} width={1440} />
<img src={extension} width={1200} />

#### Mobile app

<img src={mobile} width={1440} />
<img src={mobile} width={1200} />

## See also

- [REP-0003: Optimistic Fast Finality](https://github.com/axieinfinity/REPs/blob/main/REP-0003.md#rewards)
- [Build a Ronin CLI](./cli.md)
* [REP-0003: Optimistic Fast Finality](https://github.com/axieinfinity/REPs/blob/main/REP-0003.md#rewards)

Check notice on line 159 in docs/validators/setup/generate-keys.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/setup/generate-keys.md#L159

[Google.Acronyms] Spell out 'REP', if it's unfamiliar to the audience.
Raw output
{"message": "[Google.Acronyms] Spell out 'REP', if it's unfamiliar to the audience.", "location": {"path": "docs/validators/setup/generate-keys.md", "range": {"start": {"line": 159, "column": 4}}}, "severity": "INFO"}
* [Build a Ronin CLI](./cli.md)

Check warning on line 160 in docs/validators/setup/generate-keys.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/validators/setup/generate-keys.md#L160

[Google.WordList] Use 'command-line tool' instead of 'CLI'.
Raw output
{"message": "[Google.WordList] Use 'command-line tool' instead of 'CLI'.", "location": {"path": "docs/validators/setup/generate-keys.md", "range": {"start": {"line": 160, "column": 18}}}, "severity": "WARNING"}