chore: add null address error

axieinfinity · Jun 25, 2024 · 127716f · 127716f
1 parent ef2adf6
commit 127716f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/RNSCommission.sol b/src/RNSCommission.sol
@@ -55,6 +55,7 @@ contract RNSCommission is Initializable, AccessControlEnumerable, INSCommission
     onlyRole(DEFAULT_ADMIN_ROLE)
   {
     if (commissionIdx >= _commissionInfos.length) revert InvalidArrayLength();
+    if (newRecipient == address(0)) revert NullAddress();
 
     _commissionInfos[commissionIdx].recipient = newRecipient;
     _commissionInfos[commissionIdx].name = newName;
@@ -98,6 +99,8 @@ contract RNSCommission is Initializable, AccessControlEnumerable, INSCommission
     uint256 sum;
 
     for (uint256 i; i < length; ++i) {
+      if (commissionInfos[i].recipient == address(0)) revert NullAddress();
+
       sum += commissionInfos[i].ratio;
       _commissionInfos.push(commissionInfos[i]);
     }

diff --git a/src/interfaces/INSCommission.sol b/src/interfaces/INSCommission.sol
@@ -23,6 +23,8 @@ interface INSCommission {
   error InvalidRatio();
   /// @dev Revert when amount of RON is invalid
   error InvalidAmountOfRON();
+  /// @dev Revert when recipient address is null
+  error NullAddress();
 
   /**
    * @dev Maximum commission percentage.