Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement the DevEnv Settings Window with Textual. #231

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

janosmurai
Copy link
Contributor

@janosmurai janosmurai commented Jan 17, 2025

Type Of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Any modification in the test cases
  • Any modification in the documentation

Checklist:

  • I have read and followed the contribution guideline.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have made corresponding changes to the documentation.

Related Issue

Closing:
DEM-267
#199

Description

The DevEnv Settings Window got reimplemented in Textual. This change was needed, because the self-made TUI elements took to much time to change/update. The DevEnv Settings Window is now complex enough to introduce a TUI library.

How Has This Been Tested?

Tested on Ubuntu 22.04, with Alacritty terminal. I tried different sizes. I tested with both commands that leads to the DevEnv Settings Window: create and modify.

Screenshots (if appropriate):

dev_env_settings_window

@janosmurai janosmurai requested a review from a team as a code owner January 17, 2025 17:00
@janosmurai janosmurai merged commit 1d1b7d6 into main Jan 17, 2025
1 check passed
@janosmurai janosmurai deleted the DEM-267 branch January 17, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant