Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow grumphp-shim to 2.x version. #27

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

rajeshreeputra
Copy link
Contributor

@rajeshreeputra rajeshreeputra commented Dec 7, 2023

Fixes #25

@hussainweb
Copy link
Member

Thanks, @rajeshreeputra. Is there any reason we should keep support for v1 of the shim? I don't think it has dependencies and so chances of conflicts with other packages is unlikely.

@rajeshreeputra
Copy link
Contributor Author

Thanks, @rajeshreeputra. Is there any reason we should keep support for v1 of the shim? I don't think it has dependencies and so chances of conflicts with other packages is unlikely.

Agree Updated to use 2.x version. Thank you!!

Copy link
Member

@hussainweb hussainweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work so far. Please look at my comment.

composer.json Show resolved Hide resolved
@hussainweb hussainweb merged commit 0671708 into axelerant:main Dec 21, 2023
@rajeshreeputra rajeshreeputra deleted the composer-dependency-updates branch December 22, 2023 04:58
@rajeshreeputra
Copy link
Contributor Author

@hussainweb when can we expect a release.

@hussainweb
Copy link
Member

hussainweb commented Dec 22, 2023

@rajeshreeputra, since this is going to be a breaking release, I will release a new major version. For that, I wanted to change a few more things. Can I get your thoughts on #12 and #21? I also created #29 for a generic discussion.

@rajeshreeputra
Copy link
Contributor Author

@rajeshreeputra, since this is going to be a breaking release, I will release a new major version. For that, I wanted to change a few more things. Can I get your thoughts on #12 and #21? I also created #29 for a generic discussion.

I believe a major version isn't necessary in this case; version 1.4.0 should suffice for this.
We can proceed with maintenance on the 1.3.x version of phpro/grumphp-shim, addressing any issues that may arise in the 1.x version of phpro/grumphp-shim and resolving them accordingly.

@hussainweb
Copy link
Member

Since we are moving to a new major version of a major dependency (GrumPHP), it is a good idea to make a new major release. I don't know what's changed between GrumPHP 1 and 2 but if there are significant changes, then users have to consciously choose to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to grumphp v2
2 participants