Added IPv6 option at client side#1456
Conversation
Documentation lacked the information of how fio handles IPv6 in client/server environment. server side option is present but it is quite unclear about how to implement in client end.
|
Please update HOWTO.rst as well. |
There was a problem hiding this comment.
From: bose-abhishek <85727318+bose-abhishek@users.noreply.github.com> Date: Thu, 25 Aug 2022 22:29:57 +0530 Subject: [PATCH] Added IPv6 option at client side Documentation lacked the information of how fio handles IPv6 in client/server environment. server side option is present but it is quite unclear about how to implement in client end. --- fio.1 | 6 ++++++ 1 file changed, 6 insertions(+)
-
The commit message should contain a Signed-off-by tag with your
real name and real email. (Note that you put it in the pull request
body now, it should've been in the commit message). -
Please word-wrap the explanation in the commit message at 72-chars.
-
Don't use a GitHub anonymous name and email as the author ("From"
header in the patch). Use a real name and a real email.
|
@bose-abhishek can you please address the two review comments? |
Documentation lacked the information of how fio handles IPv6 in client/ server environment. Server side option is present but it is quite unclear about how to implement in client end. Signed-off-by: Abhishek Bose abose@redhat.com
Documentation lacked the information of how fio handles IPv6 in client/ server environment. Server side option is present but it is quite unclear about how to implement in client end. Signed-off-by: Abhishek Bose abose@redhat.com
ammarfaizi2
left a comment
There was a problem hiding this comment.
Merge branch 'axboe:master' into patch-1
-
Please do not make a merge commit when you sync your branch with
upstream. This is not necessary. Please rebase your commits on
top of the upstream HEAD commit (axboe/fio master), then do a force
push. -
Please drop your old commit. This branch still contains a commit
that was done wrong. -
The Signed-off-by format is wrong, the correct one looks like this:
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Signed-off-by:.- Name.
- Email wrapped with angle brackets.
- Please put a blank line before the
Signed-off-byline.
Added IPv6 option at client side
Documentation lacked the information of how fio handles IPv6 in client/server environment.
server side option is present but it is quite unclear about how to implement in client end.
Signed-off-by: Abhishek Bose abose@redhat.com