Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust to 1.78.0 in actions runner #780

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

jpculp
Copy link
Contributor

@jpculp jpculp commented Jul 8, 2024

Description of changes:

Bumps rust to 1.78.0 and addresses the clippy warnings that came with it.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jpculp jpculp requested a review from bcressey July 8, 2024 23:41
@bcressey
Copy link
Contributor

We need to update cargo deny to fix this error:

cargo deny --all-features check --disable-fetch licenses bans sources
thread '<unnamed>' panicked at /home/runner/work/tough/tough/.cargo/registry/src/index.crates.io-6f17d22bba15001f/krates-0.14.0/src/builder.rs:791:47:
called `Option::unwrap()` on a `None` value

I'd prefer to keep _extra as-is and just add a lints table to the workspace Cargo.toml to allow it.

Also addressed new clippy warnings.
@jpculp
Copy link
Contributor Author

jpculp commented Jul 17, 2024

@jpculp jpculp marked this pull request as ready for review July 17, 2024 00:19
Comment on lines -376 to -380
#[snafu(display("Failed writing target data to disk: {}", source))]
WriteTarget {
source: std::io::Error,
backtrace: Backtrace,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised that so many errors end up unused.

Over in the core kit, when I was working on signpost, I noticed that a lot of the new "unused" warnings were false positives. Seems to be an issue with a crate that's built as both a library and a binary - the error variants that aren't used in the library side get flagged even though the binary needs them.

Which is to say, please double check via git grep or rg that all of these are actually not used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a couple of these might have just been copied from tough at some point. I wasn't able to find any references in tuftool itself.

@jpculp jpculp requested a review from cbgbt July 17, 2024 18:26
@jpculp jpculp merged commit 8fb4469 into awslabs:develop Jul 19, 2024
7 checks passed
@jpculp jpculp deleted the rust-bump branch July 19, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants