Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify state storage to handle multiple members in the same group #124

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mulmarta
Copy link
Contributor

In general, there is no reason why a storage can't support multiple members in a single group. The new group state identifier is therefore (group_id, leaf_index) instead of just group_id.

Group states stored in the old way can be recovered using load_group(group_id).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner March 19, 2024 13:36
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 99.21875% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.38%. Comparing base (5235fc8) to head (fd7d8b2).

Files Patch % Lines
mls-rs/src/group/state_repo.rs 98.41% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   89.34%   89.38%   +0.03%     
==========================================
  Files         173      173              
  Lines       31375    31454      +79     
==========================================
+ Hits        28032    28114      +82     
+ Misses       3343     3340       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mulmarta mulmarta marked this pull request as draft March 19, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants