Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ARM runner #788

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+121 −126
Open

Use ARM runner #788

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2fa7cd
Use ARM runner
richarddavison Jan 17, 2025
bedd15a
Fix skipped test
richarddavison Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,29 +80,14 @@ jobs:
with:
toolchain: ${{ inputs.toolchain }}
- name: Run tests
if: (inputs.arch != 'aarch64' || inputs.platform != 'linux') && inputs.platform != 'windows'
if: inputs.platform == 'linux'
Copy link
Contributor

@nabetti1720 nabetti1720 Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under this condition, the macos test seems to be skipped.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice catch!

run: |
make test-ci 2>&1
- name: Run tests on windows
if: inputs.platform == 'windows'
shell: msys2 {0}
run: |
make test-ci 2>&1
- name: Run tests on aarch64-linux
if: inputs.arch == 'aarch64' && inputs.platform == 'linux'
env:
_VIRTUAL_ENV: qemu-aarch64
CARGO_TARGET_AARCH64_UNKNOWN_LINUX_MUSL_RUNNER: qemu-aarch64
TEST_TIMEOUT: 20000
run: |
sudo apt-get install -y \
qemu-system-arm \
qemu-efi-aarch64 \
qemu-utils \
qemu-user
make CURRENT_TARGET=aarch64-unknown-linux-musl test-ci
- name: Build Linux binaries
if: inputs.release && inputs.platform == 'linux'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
platform: linux
arch: x86_64
toolchain: nightly
- os: ubuntu-latest
- os: ubuntu-24.04-arm
platform: linux
arch: aarch64
toolchain: nightly
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
platform: linux
arch: x86_64
toolchain: stable
- os: ubuntu-latest
- os: ubuntu-24.04-arm
platform: linux
arch: aarch64
toolchain: stable
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
platform: linux
arch: x86_64
release: x64
- os: ubuntu-latest
- os: ubuntu-24.04-arm
platform: linux
arch: aarch64
release: arm64
Expand Down Expand Up @@ -59,6 +59,7 @@ jobs:
uses: softprops/action-gh-release@v2
with:
body_path: ./CHANGELOG.md
preserve_order: true
prerelease: contains(github.ref, 'beta') || contains(github.ref, 'alpha') || contains(github.ref, 'rc')
files: |
./llrt-lambda-x64.zip
Expand Down Expand Up @@ -88,12 +89,11 @@ jobs:
./llrt-windows-x64.zip
./llrt-windows-x64-no-sdk.zip
./llrt-windows-x64-full-sdk.zip
# Publish is broken until we stabilize a version of rquickjs
# publish:
# needs:
# - build
# uses: ./.github/workflows/publish.yml
# with:
# ref: ${{ github.ref }}
# secrets:
# CRATES_IO_TOKEN: ${{ secrets.CRATES_IO_TOKEN }}
publish:
needs:
- build
uses: ./.github/workflows/publish.yml
with:
ref: ${{ github.ref }}
secrets:
CRATES_IO_TOKEN: ${{ secrets.CRATES_IO_TOKEN }}
Loading