Taints & Node Selector for Prometheus, Cluster Role Tasks and follow ups for #325 #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an extra dedicated ASG for scheduling Prometheus monitoring pod. Signed-off-by: Ashish Ranjan <[email protected]>
This commit adds cluster name label patch for prometheus monitoring. Signed-off-by: Ashish Ranjan <[email protected]>
This commit adds node selector with monitoring asg to Prometheus manifest so that it is always tied to correct node. Signed-off-by: Ashish Ranjan <[email protected]>
This commit moves cw-metrics file to addons to folder and corrects exit code. Signed-off-by: Ashish Ranjan <[email protected]>
|
/assign @mengqiy @hakuna-matatah |
This commit adds prometheus label for s3 result path. Signed-off-by: Ashish Ranjan <[email protected]>
mengqiy
reviewed
Dec 6, 2022
This commit updates load test to utilize tekton result for passing s3_path. Signed-off-by: Ashish Ranjan <[email protected]>
This commit refactors mng create task based on comments provided on Signed-off-by: Ashish Ranjan <[email protected]>
This commit adds tasks for cluster role creation. Signed-off-by: Ashish Ranjan <[email protected]>
ashishranjan738
changed the title
This commit updates pipelines with role creation tasks. Signed-off-by: Ashish Ranjan <[email protected]>
ashishranjan738
force-pushed
the
prometheus-monitoring-rebase
branch
from
a39d326 to
d463bb6
Compare
ashishranjan738
force-pushed
the
prometheus-monitoring-rebase
branch
from
000c8db to
22c7306
Compare
mengqiy
reviewed
Dec 8, 2022
mengqiy
reviewed
Dec 8, 2022
This commit refactors role creation tasks. Signed-off-by: Ashish Ranjan <[email protected]>
ashishranjan738
force-pushed
the
prometheus-monitoring-rebase
branch
from
22c7306 to
1d6b2a8
Compare
This comit updates role task name. Signed-off-by: Ashish Ranjan <[email protected]>
This commit updates logic to use Role Names instead of Role ARNs. Signed-off-by: Ashish Ranjan <[email protected]>
ashishranjan738
force-pushed
the
prometheus-monitoring-rebase
branch
from
867d34d to
61f2eba
Compare
ashishranjan738
force-pushed
the
prometheus-monitoring-rebase
branch
from
61f2eba to
cd25b1e
Compare
This commit removes default value for role names. Signed-off-by: Ashish Ranjan <[email protected]>
ashishranjan738
force-pushed
the
prometheus-monitoring-rebase
branch
from
cd25b1e to
f92f827
Compare
Signed-off-by: Ashish Ranjan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces node selector and node taint patch for scheduling CL2 prometheus and also adds other minor fixes discussed in PR #325 like parameterizing instance types in load test, cluster role creation tasks, moving cw-metrics file to addons and adding cluster-name label in prometheus.