Podidentity #207
Open
Podidentity #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
June 20, 2024 00:28
satishbpatil
requested review from
vara-bonthu,
nimakaviani,
candonov,
csantanapr,
7navyasa,
johnphilips3 and
edgarsilva948
as code owners
candonov
reviewed
Aug 7, 2024
| @@ -52,7 +52,7 @@ spec: | |||
| type: object | |||
| required: | |||
| - providerConfigName | |||
| - region | |||
| # - region | |||
There was a problem hiding this comment.
Why is region commented out? If not required, remove it.
| enabled: true | ||
| access: irsa |
There was a problem hiding this comment.
add a comment, # options: irsa, podidentity; defaults to irsa
There was a problem hiding this comment.
Can we sync up on this diagram? I'd like to understand it better.
candonov
reviewed
Aug 7, 2024
| @@ -1,21 +1,24 @@ | |||
| apiVersion: apps/v1 | |||
| kind: Deployment | |||
| metadata: | |||
| name: {{ include "s3-irsa-app.name" . }} | |||
| rollme: {{ randAlphaNum 5 | quote }} | |||
There was a problem hiding this comment.
What is the purpose of this line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
More
Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
Yes, I have added a new example under examples to support my PR
Yes, I have updated the docs for this feature
Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)
Note:
For Moderators
Additional Notes