Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting ArgoCD Health Status for Crossplane/Upbound Specific Kinds #198

Merged

Conversation

hflobao
Copy link
Contributor

@hflobao hflobao commented Jun 7, 2024

What does this PR do?

Change the Lua code in the resource.customizations to address situations where Composite Resources stay in the Provisioning status forever, mainly for the ProviderConfig Kind.
It add tests for specific Kinds that does not have status or have just a status.users field. It also adds tests for the helm provider CRDs.
Based on the guide on https://docs.crossplane.io/latest/guides/crossplane-with-argo-cd/

Motivation

To have a Composition deployed with ArgoCD and all resources with a green health status.
In the case of the Composition I was building, the ProviderConfig for kubernetes and for helm needed this fix to became green.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

  • Not all the PRs require examples and docs
  • We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@edgarsilva948
Copy link
Collaborator

thanks for the PR @hflobao! Great stuff. Keep it coming! :)

@edgarsilva948
Copy link
Collaborator

@candonov LGTM!

@edgarsilva948 edgarsilva948 merged commit 38c6587 into awslabs:main Jun 7, 2024
1 check passed
Copy link
Contributor

@candonov candonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants