Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding composition for aws aurora db & proxy #137

Merged
merged 25 commits into from
Sep 14, 2023
Merged

Conversation

biswajitbabu
Copy link
Contributor

What does this PR do?

Adding composition for AWS Aurora PostgreSQL DB and the proxy for the DB

Motivation

We are looking for an composition which provisions an aurora PostgreSQL database and we created the composition for one of our client . Community can take benefit of this composition .

More

  • [y ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • [ y] Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

  • Not all the PRs require examples and docs
  • We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Adding composition for aws aurora db
Copy link
Contributor

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crossplane allows you create these IAM roles you are creating manually. Could you tell me why they are not part of a composition?

You should also document clean up process in the doc. Please also remove leading spaces in commands. Makes it hard to copy and paste.

Copy link
Contributor

@candonov candonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much for this!

@nabuskey nabuskey merged commit df8117b into awslabs:main Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants