-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding composition for aws aurora db & proxy #137
Conversation
Adding composition for aws aurora db
examples/upbound-aws-provider/composite-resources/aurora-postgresql.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crossplane allows you create these IAM roles you are creating manually. Could you tell me why they are not part of a composition?
You should also document clean up process in the doc. Please also remove leading spaces in commands. Makes it hard to copy and paste.
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/--policy-document
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/--policy-name
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/psql-client-pod.yaml
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/rdsproxy-access.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
...les/upbound-aws-provider/composite-resources/database-examples/aurora/aurora-postgresql.yaml
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/database-examples/aurora/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you very much for this!
What does this PR do?
Adding composition for AWS Aurora PostgreSQL DB and the proxy for the DB
Motivation
We are looking for an composition which provisions an aurora PostgreSQL database and we created the composition for one of our client . Community can take benefit of this composition .
More
[y ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[ y] Yes, I have added a new example under examples to support my PR
Yes, I have updated the docs for this feature
Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)
Note:
For Moderators
Additional Notes