Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Replace resourceConfig with commonConfig accross the repo #148

Open
candonov opened this issue Sep 12, 2023 · 1 comment
Open

[FEATURE] Replace resourceConfig with commonConfig accross the repo #148

candonov opened this issue Sep 12, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@candonov
Copy link
Contributor

candonov commented Sep 12, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe

resourceConfig was designed to contain commonalities for all resources such as:

  • deletionPolicy
  • name
  • region
  • tags
  • providerConfigName

but the name resource is too generic and leads usage confusion.

Describe the solution you'd like

  • rename resourceConfig to commonConfig to avoid the confusion
  • deletionPolicy is being deprecated, replace with managementPolicies
  • set a default providerConfigName to aws-provider-config and remove from claims
@candonov
Copy link
Contributor Author

@nabuskey fyi

@candonov candonov mentioned this issue Sep 12, 2023
Merged
3 tasks
@candonov candonov added the good first issue Good for newcomers label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@candonov