Skip to content

Commit

Permalink
#698 and #695
Browse files Browse the repository at this point in the history
  • Loading branch information
eamonnfaherty committed Jan 4, 2024
1 parent 2c58ec5 commit de3fa36
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

[tool.poetry]
name = "aws-service-catalog-puppet"
version = "0.244.0"
version = "0.245.0"
description = "Making it easier to deploy ServiceCatalog products"
classifiers = ["Development Status :: 5 - Production/Stable", "Intended Audience :: Developers", "Programming Language :: Python :: 3", "License :: OSI Approved :: Apache Software License", "Operating System :: OS Independent", "Natural Language :: English"]
homepage = "https://service-catalog-tools-workshop.com/"
Expand Down
1 change: 1 addition & 0 deletions servicecatalog_puppet/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,7 @@ def set_config_value(name, value):
is_a_boolean = dict(
spoke_deploy_environment_compute_type=False,
scheduler_threads_or_processes=False,
aws_sts_regional_endpoints=False,
).get(name, True)
management_commands.set_config_value(name, value, is_a_boolean)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
AWSTemplateFormatVersion: "2010-09-09"
Description: |
Initialiser template used to bring up the install ServiceCatalog-Puppet
{"version": "0.223.0", "framework": "servicecatalog-puppet", "role": "initialiser"}
{"version": "0.245.0", "framework": "servicecatalog-puppet", "role": "initialiser"}
Metadata:
AWS::CloudFormation::Interface:
Expand All @@ -13,6 +13,7 @@ Metadata:
default: "General"
Parameters:
- EnabledRegions
- AWSSTSRegionalEndPoints
- ShouldCollectCloudformationEvents
- ShouldForwardEventsToEventbridge
- ShouldForwardFailuresToOpscenter
Expand Down Expand Up @@ -127,6 +128,14 @@ Parameters:
- True
- False
Default: True
AWSSTSRegionalEndPoints:
Type: String
Description: |
This setting specifies how the SDK determines the AWS service endpoint that it uses to talk to the AWS Security Token Service (AWS STS).
AllowedValues:
- legacy
- regional
Default: legacy
ShouldUseStacksServiceRole:
Type: String
Description: |
Expand Down Expand Up @@ -420,6 +429,9 @@ Resources:
- Name: SHOULD_SHARE_PRINCIPALS
Type: PLAINTEXT
Value: !Ref ShouldSharePrincipals
- Name: AWS_STS_REGIONAL_ENDPOINTS
Type: PLAINTEXT
Value: !Ref AWSSTSRegionalEndPoints
Source:
Type: NO_SOURCE
BuildSpec: |
Expand All @@ -440,6 +452,7 @@ Resources:
- servicecatalog-puppet set-config-value spoke_deploy_environment_compute_type ${SPOKE_DEPLOY_ENVIRONMENT_COMPUTE_TYPE}
- servicecatalog-puppet set-config-value global_share_tag_options_default ${SHOULD_SHARE_TAG_OPTIONS}
- servicecatalog-puppet set-config-value global_share_principals_default ${SHOULD_SHARE_PRINCIPALS}
- servicecatalog-puppet set-config-value aws_sts_regional_endpoints ${AWS_STS_REGIONAL_ENDPOINTS}
- servicecatalog-puppet bootstrap-spoke ${PUPPET_ACCOUNT_ID} --permission-boundary ${PUPPET_ROLE_PERMISSION_BOUNDARY} --puppet-role-name ${PUPPET_ROLE_NAME} --puppet-role-path ${PUPPET_ROLE_PATH}
build:
commands:
Expand Down Expand Up @@ -471,7 +484,7 @@ Resources:
Role: !GetAtt StartInstallRole.Arn
Handler: "index.handler"
Description: Lambda for starting Puppet CodeBuild Job
Runtime: python3.7
Runtime: python3.9
Timeout: 900
Code:
ZipFile: |
Expand Down Expand Up @@ -583,6 +596,7 @@ Resources:
- !Ref ShouldDeleteRollbackCompleteStacks
- !Ref ShouldShareTagOptions
- !Ref ShouldSharePrincipals
- !Ref AWSSTSRegionalEndPoints
Outputs:
ServiceCatalogPuppetRepoConsoleURL:
Value: !Sub "https://${AWS::Region}.console.aws.amazon.com/codesuite/codecommit/repositories/ServiceCatalogPuppet/browse"
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@

setup_kwargs = {
'name': 'aws-service-catalog-puppet',
'version': '0.244.0',
'version': '0.245.0',
'description': 'Making it easier to deploy ServiceCatalog products',
'long_description': '# aws-service-catalog-puppet\n\n![logo](./docs/logo.png) \n\n## Badges\n\n[![codecov](https://codecov.io/gh/awslabs/aws-service-catalog-puppet/branch/master/graph/badge.svg?token=e8M7mdsmy0)](https://codecov.io/gh/awslabs/aws-service-catalog-puppet)\n\n\n## What is it?\nThis is a python3 framework that makes it easier to share multi region AWS Service Catalog portfolios and makes it \npossible to provision products into accounts declaratively using a metadata based rules engine.\n\nWith this framework you define your accounts in a YAML file. You give each account a set of tags, a default region and \na set of enabled regions.\n\nOnce you have done this you can define portfolios should be shared with each set of accounts using the tags and you \ncan specify which regions the shares occur in.\n\nIn addition to this, you can also define products that should be provisioned into accounts using the same tag based \napproach. The framework will assume role into the target account and provision the product on your behalf.\n\n\n## Getting started\n\nYou can read the [installation how to](https://service-catalog-tools-workshop.com/30-how-tos/10-installation/30-service-catalog-puppet.html)\nor you can read through the [every day use](https://service-catalog-tools-workshop.com/30-how-tos/50-every-day-use.html)\nguides.\n\nYou can read the [documentation](https://aws-service-catalog-puppet.readthedocs.io/en/latest/) to understand the inner \nworkings. \n\n\n## Going further\n\nThe framework is one of a pair. The other is [aws-service-catalog-factory](https://github.com/awslabs/aws-service-catalog-factory).\nWith Service Catalog Factory you can create pipelines that deploy multi region portfolios very easily. \n\n## License\n\nThis library is licensed under the Apache 2.0 License. \n \n',
'author': 'Eamonn Faherty',
Expand Down

0 comments on commit de3fa36

Please sign in to comment.