Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fetcher interface data type #191

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

hakanson
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Fixed tsc compile error when tsconfig.json has "skipLibCheck": false for a web application
    Type 'Buffer<ArrayBufferLike> | undefined' is not assignable to type 'ArrayBuffer | undefined'.
  • added a Cypress SimpleFetcher test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hakanson hakanson requested a review from ottokruse January 18, 2025 18:02
@ottokruse ottokruse merged commit 009436a into awslabs:main Jan 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants