Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate the configured region to the S3 client #600

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

sielenk-yara
Copy link
Contributor

This is a fix for issue #599.

Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however I think a unit test should be added to assert that the region is set.

@sielenk-yara sielenk-yara force-pushed the fix-region-propagation branch 2 times, most recently from b169f7a to af93f4e Compare January 29, 2025 09:30
@sielenk-yara
Copy link
Contributor Author

Sorry, didn't notice I need to re-request a review. This one should be good to go.

Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the contribution

@markjschreiber markjschreiber merged commit 1d2c9c9 into awslabs:main Feb 4, 2025
1 check passed
@sielenk-yara sielenk-yara deleted the fix-region-propagation branch February 5, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants