fix: removed the configuration from the filesystem provider and used the one in the filesystem instead. #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markjschreiber
requested changes
Jan 17, 2025
sielenk-yara
force-pushed
the
fix-configuration-scope
branch
from
bd49948 to
800dc6d
Compare
sielenk-yara
force-pushed
the
fix-configuration-scope
branch
2 times, most recently
from
1f7a562 to
615d917
Compare
|
Since this is not possible without breaking changes, do you want to leave this PR pending until the next major release happens? |
|
We could definitely deprecate the old method. I'm also wondering if there is a way that the old method can call the new method in the Either way, even without a major version change we should deprecate the old method and tell people to use the new one instead and then remove the deprecated method with the next major version. Especially as the old method has limited utility. |
sielenk-yara
force-pushed
the
fix-configuration-scope
branch
2 times, most recently
from
e229de4 to
6bf4de9
Compare
…the one in the filesystem instead.
sielenk-yara
force-pushed
the
fix-configuration-scope
branch
from
6bf4de9 to
c583d74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #597.