Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logback): Fix logback.xml file interfere with project's default config #200

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

guicamest
Copy link
Contributor

Issue #154

Description of changes:
This PR moves the logback.xml from src/main into src/test so that:

  • Fixes the interference issue
  • Logs in tests are formatted as defined and log levels can be configured

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR

@markjschreiber markjschreiber merged commit 2eb44e4 into awslabs:main Oct 3, 2023
1 check passed
@guicamest guicamest deleted the iss-154-logback-xml branch October 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants