Feat/event bus #528
Open
Feat/event bus #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignoring check I3042 for cfn-lint Adding in EventBus to deployment account Adding in x-ray tracing to pipeline management lambda functions Changing event content, adding in xray layer to pipeline management lambda functions Documentation Mega Lint Fixes Forgot to hit save :(
StewartW
force-pushed
the
feat/event-bus
branch
from
b63e548
to
e011008
Compare
StewartW
commented
Sep 8, 2022
...odebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/pipeline_management.yml
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/events.py
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/events.py
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/events.py
Show resolved
Hide resolved
javydekoning
requested changes
Sep 14, 2022
src/lambda_codebase/account_processing/configure_account_alias.py
Outdated
Show resolved
Hide resolved
src/lambda_codebase/account_processing/configure_account_alias.py
Outdated
Show resolved
Hide resolved
src/lambda_codebase/account_processing/configure_account_tags.py
Outdated
Show resolved
Hide resolved
...repository/adf-bootstrap/deployment/lambda_codebase/pipeline_management/create_repository.py
Outdated
Show resolved
Hide resolved
|
Please pull in latest commits from |
|
Hey @javydekoning Are we allowed to run black now those linter changes are in master? I've always held off using it |
There is no "black" linter yet. However, we are now enforcing a max line length via |
…into feat/event-bus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Introduces an Event Bus to the root account, in the primary region. (us-east-1 if the aws parititon, us-gov-west-1, if the aws-gov partition.)
Instruments the account management lambda functions and state machine to emit events on certain actions.
Event Bus Policy allows any role within the deployment account and within the adf-automation path to putEvents onto the EventBus.
This enables the Pipeline Management Lambda Functions to push events as well.
Also introduces a new layer for the pipeline management lambda functions that contains the pip installed dependencies and a new aws-xray-sdk requirement, which enables tracing of the lambda functions themselves.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.