Fix additional warnings found by the Undefined Behavior Sanitizer#531
Open
bjosv wants to merge 3 commits intoawslabs:mainfrom
Open
Fix additional warnings found by the Undefined Behavior Sanitizer#531bjosv wants to merge 3 commits intoawslabs:mainfrom
bjosv wants to merge 3 commits intoawslabs:mainfrom
Conversation
Fixes runtime error warnings found when running the tests in the "aws-crt-cpp" repo with the undefined behavior sanitizer enabled. "runtime error: call to function aws_byte_cursor_eq through pointer to incorrect function type 'bool (*)(const void *, const void *)'" Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Contributor
Author
|
As a update; |
Contributor
Author
|
@TingDaoK I see that aws-c-http is running sanitizers in CI, but without the |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes runtime error warnings found when running tests in the aws-crt-cpp repo with the undefined behavior sanitizer enabled.
Description of changes:
Add callback functions that uses correct signature aws_hash_callback_eq_fn (as also seen in aws-c-mqtt).
Since the CI-build is not using
-fno-sanitize-recover=all, and the warnings are recoverable, they will not fail the CI build.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.