Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(al2): change cni plugins source and update version #2048

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ndbaker1
Copy link
Member

@ndbaker1 ndbaker1 commented Nov 12, 2024

Issue #, if available:

Description of changes:

Updates the binary artifact storage scheme for the cni-plugins bundle

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

make k8s=1.31 ami_name=binaries-pull os_distro=al2 pull_cni_from_github=false binary_bucket_name=***

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

@ndbaker1 ndbaker1 changed the title Update logic for pulling cni plugins and bump version deps(al2): update logic for pulling cni plugins and bump version Nov 12, 2024
templates/al2/provisioners/install-worker.sh Outdated Show resolved Hide resolved
local binary_name=""
local os="linux"
local arch="$ARCH"
local version=""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how could we support a version marker for binaries? e.g.

bin/$binary_name/latest.txt => 1.2.3

bin/$binary_name/1.2.3/$os/$arch/$binary_name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm on board with this marker, but I don't think i'm going to make any change in this PR to facilitate any kind of latest or * pointer yet. it'll suffice for now to allow populating cni_plugin_version manually with the value of $(curl https://amazon-eks.s3.us-west-2.amazonaws.com/cni-plugins/latest.txt)

@ndbaker1 ndbaker1 changed the title deps(al2): update logic for pulling cni plugins and bump version build(al2): change cni plugins source and update version Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants