Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superseded Symphonia Lambda-Logging con Lambda Powertools #553

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ccolon11
Copy link

@ccolon11 ccolon11 commented May 5, 2023

*Issue:
#496
*Description of changes:
Replace Symphonia Lambda-Logging with Lambda Powertools,
the corresponding Symphonia Lambda-Logging dependencies were removed and in the same way log4j2.xml was made the necessary modifications, both in a previous merge in the main branch

By submitting this pull request

  • [X ] I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • [X ] I confirm that I've made a best effort attempt to update all relevant documentation.

@deki deki added this to the Release 2.0 milestone May 5, 2023
Copy link
Collaborator

@deki deki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ccolon11, thanks again for your contribution. You mention you modified the log4j2.xml files as well. Can you please add these changes to the PR?

@ccolon11
Copy link
Author

ccolon11 commented May 6, 2023

I don't problem in making it.
can @deki indicate me exactly,
¿what ought making in log4j2.xml files?
for not to make errors, only there is to replace the corresponding code lines for that appearing in the follow link:
https://awslabs.github.io/aws-lambda-powertools-java/core/logging/

@deki
Copy link
Collaborator

deki commented May 8, 2023

Hi,
with the current change no powertools features are used so it would be even enough to use https://github.com/aws/aws-lambda-java-libs/tree/main/aws-lambda-java-log4j2.

I'd check the log output before and after the change. Goal is to provide a meaningful example that shows at least the Lambda Request ID as part of the log output and demonstrates 1-2 powertools features.

@deki deki removed this from the Release 2.0 milestone Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants