Fix mlflow (oss models) metrics viz - #6102
Merged
mujtaba1747 merged 4 commits intoJul 27, 2026
Merged
Conversation
mujtaba1747
changed the title
| # calling display(fig) directly we render to an in-memory PNG and embed | ||
| # it inside a scrollable HTML <div>. This lets the notebook display all | ||
| # metrics without choking on pixel-count limits. | ||
| import io |
Contributor
There was a problem hiding this comment.
nit: these should move to the top level
|
|
||
| # Embed as a scrollable HTML image in the notebook | ||
| b64 = base64.b64encode(buf.getvalue()).decode() | ||
| from IPython.display import HTML |
Contributor
There was a problem hiding this comment.
Should this also be top level?
Collaborator
Author
There was a problem hiding this comment.
Agreed. Will move it.
amazeAmazing
approved these changes
Jul 27, 2026
zhaoqizqwang
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix related to mlflow (oss models) metrics visualization.
1.
plot_training_metricsfailed to render tall figures inlineWhen plotting many metrics, the combined figure grew too tall for the
inline backend to rasterize, so
display(fig)produced no output. Asingle-metric run also broke because
plt.subplotsreturned a bare Axesthat couldn't be flattened.
Changes:
squeeze=Falsetoplt.subplotssoaxesis always a 2D arraythat can be flattened, fixing the single-metric case
HTML
<div>, allowing all metrics to display without hitting thebackend's pixel-count limits
Testing
metrics
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.