Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v1.10.2 #531

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

release: v1.10.2 #531

wants to merge 20 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request was created by GitHub Actions/AWS CodeBuild! Before merging, please do the following:

  • Review changelog/staleness report.
  • (Only for Minor/Major version releases) Review python package dependency and size report.
  • Review build/test results by clicking Build Logs in CI Report (be patient, tests take ~4hr).
  • Review ECR Scan results.

@TRNWWZ
Copy link
Contributor

TRNWWZ commented Dec 24, 2024

along with the release of npm 1.11.0 last week: https://github.com/npm/cli/releases/tag/v11.0.0, we starts to seeing image build failure due to this line: https://github.com/aws/sagemaker-distribution/blame/main/template/v1/Dockerfile#L93. The reason is:

  • npm i -g npm will try installing latest version of npm, it used to work because the NodeJS version we installed was compatible with NPM 1.10.x which is the latest version, but now it's no longer the latest version
  • In SMD V1, we have conda-forge::nodejs[version='>=18.20.3,<18.21.0'], which blocks NPM version upgrade from 1.10.x to 1.11.x, so now npm i -g npm command fails the image build process

As the fix, I'm replacing the command to npm update -g npm in this PR, which will try updating NPM to the latest compatible version.

@@ -90,7 +90,7 @@ ARG MAMBA_DOCKERFILE_ACTIVATE=1
RUN sudo ln -s $(which python3) /usr/bin/python

# Update npm version
RUN npm i -g npm
RUN RUN npm update -g npm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated "RUN" command

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'm making change to reduce RUN command in both v1.10.2 and v1 template in this PR

@TRNWWZ TRNWWZ restored the release-1.10.2 branch December 24, 2024 17:28
@TRNWWZ TRNWWZ reopened this Dec 24, 2024
@sagemaker-distribution-bot sagemaker-distribution-bot deleted the release-1.10.2 branch December 25, 2024 00:06
@TRNWWZ TRNWWZ restored the release-1.10.2 branch December 25, 2024 00:13
@TRNWWZ TRNWWZ reopened this Dec 25, 2024
@TRNWWZ TRNWWZ restored the release-1.10.2 branch December 27, 2024 17:47
@TRNWWZ TRNWWZ reopened this Dec 27, 2024
@sagemaker-distribution-bot sagemaker-distribution-bot deleted the release-1.10.2 branch December 28, 2024 01:06
@TRNWWZ TRNWWZ restored the release-1.10.2 branch December 28, 2024 01:33
@TRNWWZ TRNWWZ reopened this Dec 28, 2024
@TRNWWZ
Copy link
Contributor

TRNWWZ commented Dec 28, 2024

FAILED test/test_dockerfile_based_harness.py::test_dockerfiles_for_gpu[keras.test.Dockerfile-required_packages0]
FAILED test/test_dockerfile_based_harness.py::test_dockerfiles_for_gpu[scipy.test.Dockerfile-required_packages5]
FAILED test/test_dockerfile_based_harness.py::test_dockerfiles_for_gpu[autogluon.test.Dockerfile-required_packages1]
FAILED test/test_dockerfile_based_harness.py::test_dockerfiles_for_gpu[sagemaker-studio-analytics-extension.test.Dockerfile-required_packages21]
FAILED test/test_dockerfile_based_harness.py::test_dockerfiles_for_gpu[pandas.test.Dockerfile-required_packages8]
FAILED test/test_dockerfile_based_harness.py::test_dockerfiles_for_gpu[sm-python-sdk.test.Dockerfile-required_packages9]
FAILED test/test_dockerfile_based_harness.py::test_dockerfiles_for_gpu[pytorch.examples.Dockerfile-required_packages10]
  • keras - Single test fails with AttributeError: 'CustomLayer' object has no attribute '_build_input_shape'. Issue with test, not installation
  • scipy - Fix Scipy tests for GPU based docker images #30
  • autogluon - ERROR: Unexpected bus error encountered in worker. docker run --gpus '"device=0"' --runtime=nvidia -it --shm-size=64g <image-id> to execute tests on single gpu with increased memory successfully
  • sagemaker-studio-analytics-extension - test passed locally, should be flaky issue.
  • pandas - single test faied with E matplotlib._api.deprecation.MatplotlibDeprecationWarning: The plot_date function was deprecated in Matplotlib 3.9 and will be removed in 3.11. Use plot instead. - should be warning, test is using deprecated function
  • sm-python-sdk - sm-python-sdk test failures #316
  • pytorch - passed when running tests in container directly, failure was caused by dependencies conflict when installing some , but not impacting functionality.

@aws aws deleted a comment from sagemaker-distribution-bot Jan 3, 2025
@aws aws deleted a comment from sagemaker-distribution-bot Jan 3, 2025
@aws aws deleted a comment from sagemaker-distribution-bot Jan 3, 2025
@sagemaker-distribution-bot sagemaker-distribution-bot deleted the release-1.10.2 branch January 3, 2025 22:05
@aws aws deleted a comment from sagemaker-distribution-bot Jan 3, 2025
@TRNWWZ TRNWWZ restored the release-1.10.2 branch January 3, 2025 22:09
@TRNWWZ TRNWWZ reopened this Jan 3, 2025
@sagemaker-distribution-bot
Copy link
Collaborator

Staleness Report: 1.10.2(gpu)

Package Current Version in the Distribution image Latest Relevant Version in Upstream
numpy 1.26.4 1.26.4
jinja2 3.1.5 3.1.5
pandas 2.1.4 2.1.4
altair 5.3.0 5.3.0
boto3 1.34.162 1.34.162
ipython 8.26.0 8.26.0
jupyter-lsp 2.2.5 2.2.5
${\color{red}jupyterlab}$ 4.1.6 4.1.8
amazon-q-developer-jupyterlab-ext 3.2.0 3.2.0
${\color{red}langchain}$ 0.2.5 0.2.17
jupyter-ai 2.20.0 2.20.0
amazon-sagemaker-jupyter-ai-q-developer 1.0.14 1.0.14
jupyter-scheduler 2.7.1 2.7.1
amazon-sagemaker-jupyter-scheduler 3.1.7 3.1.7
amazon-sagemaker-sql-magic 0.1.3 0.1.3
jupyterlab-lsp 5.0.3 5.0.3
amazon_sagemaker_sql_editor 0.1.14 0.1.14
scipy 1.11.4 1.11.4
scikit-learn 1.4.2 1.4.2
pip 23.3.2 23.3.2
torchvision 0.15.2 0.15.2
autogluon 0.8.3 0.8.3
ipywidgets 8.1.5 8.1.5
notebook 7.1.3 7.1.3
aws-glue-sessions 1.0.7 1.0.7
${\color{red}libmamba}$ 1.5.11 1.5.12
conda 23.11.0 23.11.0
fastapi 0.110.3 0.110.3
jupyter-collaboration 1.1.0 1.1.0
jupyter-dash 0.4.2 0.4.2
jupyter-server-proxy 4.3.0 4.3.0
jupyterlab-git 0.50.2 0.50.2
keras 2.14.0 2.14.0
langchain-aws 0.1.18 0.1.18
matplotlib 3.9.4 3.9.4
${\color{red}nodejs}$ 18.20.3 18.20.5
py-xgboost-gpu 1.7.6 1.7.6
thrift_sasl 0.4.3 0.4.3
pyhive 0.7.0 0.7.0
python-gssapi 1.8.3 1.8.3
python-lsp-server 1.11.0 1.11.0
pytorch-gpu 2.0.0 2.0.0
sagemaker-code-editor 1.1.5 1.1.5
sagemaker-headless-execution-driver 0.0.13 0.0.13
sagemaker-jupyterlab-emr-extension 0.3.4 0.3.4
sagemaker-jupyterlab-extension 0.3.2 0.3.2
sagemaker-kernel-wrapper 0.0.4 0.0.4
sagemaker-python-sdk 2.227.0 2.227.0
sagemaker-studio-analytics-extension 0.1.2 0.1.2
sasl 0.3.1 0.3.1
supervisor 4.2.5 4.2.5
tensorflow-gpu 2.14.0 2.14.0
uvicorn 0.30.6 0.30.6

Staleness Report: 1.10.2(cpu)

Package Current Version in the Distribution image Latest Relevant Version in Upstream
numpy 1.26.4 1.26.4
jinja2 3.1.5 3.1.5
pytorch 2.0.0 2.0.0
pandas 2.1.4 2.1.4
altair 5.3.0 5.3.0
boto3 1.34.162 1.34.162
ipython 8.26.0 8.26.0
jupyter-lsp 2.2.5 2.2.5
${\color{red}jupyterlab}$ 4.1.6 4.1.8
amazon-q-developer-jupyterlab-ext 3.2.0 3.2.0
${\color{red}langchain}$ 0.2.5 0.2.17
jupyter-ai 2.20.0 2.20.0
amazon-sagemaker-jupyter-ai-q-developer 1.0.14 1.0.14
jupyter-scheduler 2.7.1 2.7.1
amazon-sagemaker-jupyter-scheduler 3.1.7 3.1.7
amazon-sagemaker-sql-magic 0.1.3 0.1.3
jupyterlab-lsp 5.0.3 5.0.3
amazon_sagemaker_sql_editor 0.1.14 0.1.14
scipy 1.11.4 1.11.4
scikit-learn 1.4.2 1.4.2
pip 23.3.2 23.3.2
torchvision 0.15.2 0.15.2
autogluon 0.8.3 0.8.3
ipywidgets 8.1.5 8.1.5
notebook 7.1.3 7.1.3
aws-glue-sessions 1.0.7 1.0.7
${\color{red}libmamba}$ 1.5.11 1.5.12
conda 23.11.0 23.11.0
fastapi 0.110.3 0.110.3
jupyter-collaboration 1.1.0 1.1.0
jupyter-dash 0.4.2 0.4.2
jupyter-server-proxy 4.3.0 4.3.0
jupyterlab-git 0.50.2 0.50.2
keras 2.15.0 2.15.0
langchain-aws 0.1.18 0.1.18
matplotlib 3.9.4 3.9.4
${\color{red}nodejs}$ 18.20.3 18.20.5
py-xgboost-cpu 1.7.6 1.7.6
thrift_sasl 0.4.3 0.4.3
pyhive 0.7.0 0.7.0
python-gssapi 1.8.3 1.8.3
python-lsp-server 1.11.0 1.11.0
sagemaker-code-editor 1.1.5 1.1.5
sagemaker-headless-execution-driver 0.0.13 0.0.13
sagemaker-jupyterlab-emr-extension 0.3.4 0.3.4
sagemaker-jupyterlab-extension 0.3.2 0.3.2
sagemaker-kernel-wrapper 0.0.4 0.0.4
sagemaker-python-sdk 2.227.0 2.227.0
sagemaker-studio-analytics-extension 0.1.2 0.1.2
sasl 0.3.1 0.3.1
supervisor 4.2.5 4.2.5
tensorflow 2.15.0 2.15.0
uvicorn 0.30.6 0.30.6

@sagemaker-distribution-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: CosmosImageBuildersagemaker-U5omrjiHQCoa
  • Commit ID: 7d22063
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants