-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v1.10.2 #531
base: main
Are you sure you want to change the base?
release: v1.10.2 #531
Conversation
along with the release of npm 1.11.0 last week: https://github.com/npm/cli/releases/tag/v11.0.0, we starts to seeing image build failure due to this line: https://github.com/aws/sagemaker-distribution/blame/main/template/v1/Dockerfile#L93. The reason is:
As the fix, I'm replacing the command to |
template/v1/Dockerfile
Outdated
@@ -90,7 +90,7 @@ ARG MAMBA_DOCKERFILE_ACTIVATE=1 | |||
RUN sudo ln -s $(which python3) /usr/bin/python | |||
|
|||
# Update npm version | |||
RUN npm i -g npm | |||
RUN RUN npm update -g npm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicated "RUN" command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'm making change to reduce RUN
command in both v1.10.2 and v1 template in this PR
This reverts commit 1c7628c.
|
Staleness Report: 1.10.2(gpu)
Staleness Report: 1.10.2(cpu)
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This pull request was created by GitHub Actions/AWS CodeBuild! Before merging, please do the following: