feat: update scripts to use OpenSSL 3 #4992
Open
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <[email protected]>
lrstewart
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Thanks for the PR!
You can ignore the "Performance Regression Test" failure-- it looks like that's failing for several PRs right now and is probably just misbehaving.
For the "macOS build and test S2n" failure, I think your problem is that script calls s2n_setup_env.sh, which sets S2N_LIBCRYPTO to "openssl-1.1.1" by default. s2n_build_test then complains that S2N_LIBCRYPTO was set to "openssl-1.1.1" but you actually built against openssl-3. You should be able to fix this by just setting S2N_LIBCRYPTO to "openssl-3.0" in the s2n_osx.sh script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
since 1.3.22 release, homebrew has switched to use openssl@3, also [email protected] has been disabled on the homebrew side for quite some time.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.