Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making sidecar to fill krb5.conf from parameters, passing DOMAIN in secret, general fixes and cleanup #151

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Making sidecar to fill krb5.conf from parameters, passing DOMAIN in secret, general fixes and cleanup #151

wants to merge 3 commits into from

Conversation

denispar
Copy link

Description of changes:

  1. Fixed Dockerfile, if had a syntax error
  2. Cleanup unused imports
  3. Added separate sleep time for failure retries (not 45 minutes)
  4. Fixed docstring for get_secret
  5. get_secret now tries to get DOMAIN_NAME from the secret along with username and password
  6. get_secret now doesn't crash everything if the secret is somehow misconfigured. Now we log and retry, the customer can fix the secret and we will pick it up on the next run.
  7. The placeholders in krb5.conf are not populated from the code according to the parameters, no need to rebuild the container to change DOMAIN_NAME.
  8. Fixed reading environment variables. os.environ values are always type str, not int as the old code assumed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jonlouie
jonlouie previously approved these changes May 1, 2022
View reviewed changes
Copy link
Contributor

@jonlouie jonlouie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this also require review from @smhmhmd?

@smhmhmd
Copy link
Contributor

smhmhmd commented May 2, 2022

I do have some concerns/questions, pls do not merge yet

jonlouie
jonlouie requested changes May 2, 2022
View reviewed changes
Templates/kerberosSideCar/krb_side_car.py
# Missing values are handled in the caller
return username, password, domain
return username, password, domain, krb5_conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update doc comment on line 58 to match

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@denispar denispar requested a review from jonlouie May 11, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eruanion Eruanion Awaiting requested review from Eruanion

@jonlouie jonlouie Awaiting requested review from jonlouie jonlouie is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denispar @smhmhmd @jonlouie