generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 83
Dev init #2393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sacrodge
wants to merge
15
commits into
aws:feature/hello-world-server
Choose a base branch
from
sacrodge:dev-init
base: feature/hello-world-server
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Dev init #2393
+498
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added support for changing the component title from LS - Final stage not wotking yet
- Styled component to be attached to chat prompt window - Set the default visibility to hidden, which is working - (x) files modified! status doesn't reflect yet
- component title now changes from LS - Need more functinalities offloaded from mynah to SL - For now working on session reset
- Have completely shifted logic to LS and only kept rendering part in mynah - Was only able to render the modified files not undo buttons - Using existing fileList and creating a new array like datastructure
- Completely refactored code to have all the logic in LS instead - mynah-ui just handles the rendering now no logic
- Shifting logic from mynahUI.ts to agenticChatController.ts - It is the correct place to have business logic, mynahui.ts is just for UI - Files are rendering but no functionality is working - LS Sever <-->IDE<-->LS Chat client-->mynahui >>>> Flow diagram
- Files are rendering, files are clickable - undo and undoall buttons are rendering and are clickable and functional - However, all the buttons are rendering separately not with the filename
- Files are being rendered and are clickable - Undo buttons per file are showing and are clickable working - Undo-all logic not correct and not working
- UndoAll button only undoes the last file modification - undo buttons work - File click works
- Files are rendering correctly with undo and undoall buttons - Buttons are all clickable and working - However, upon multiple chats, sometimes nothing is rendering - need further testing
- Files are rendering correctly with undo and undoall buttons - Buttons are all clickable and working - However, the sessions are probably not clearing correctly
- Files, buttons rendering and fully functional - session manager is clearing older files for every new chat - blockers : undoall is rendered too early - component should hide initially and show working when prompted - If no files were modified as a result of the chat it should hide again
- Now session clearing works as expected and shows current file in diff mode - However, since I am clearing the toolUse data if user clicks on previous files from earlier chat - they won't see the file in diff. Nothing will actually happen at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Creating a separate component to display just modified files in
Solution
Moved most of the logic from mynahUI.ts but it still has some logic.
Currently bypasses the LSP and backend directly updates the UI. Created separate branch for tackling this issue.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.