feat: Add support for custom ssm parameters in amiSelectorTerms #7341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wesley-yep-canva
force-pushed
the
feat-custom-ssm-paramters-for-ami-selector-terms
branch
2 times, most recently
from
6ff77e6 to
b0d3183
Compare
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
wesley-yep-canva
force-pushed
the
feat-custom-ssm-paramters-for-ami-selector-terms
branch
from
9347ba5 to
ee3fd83
Compare
|
/remove-lifecycle stale |
|
Hey @wesley-yep-canva sorry that it's taken us so long to get around to this stuff :) Team has been pretty back-logged. Since this is a feature, there's also going to be some discussion around it I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3657
Description
Adds
ssmParameterNametoamiSelectorTermsto allow Karpenter to read a custom ssm parameter to get the AMI Image ID.Karpenter already has ssm parameter IAM permissions and a ssm provider class as it's used to retrieve the public ssm params for alias based amiSelectorTerms. The reason I've added a separate function
GetCustomParameterto the ssm provider is because we'd prefer not to use the cache for custom parameters, since it won't suffer from the same "thundering herd" behavior compared to if a public parameter was changed.How was this change tested?
make testDoes this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.