Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cp(v0.36.x): feat: invalidate SSM cache upon AMI deprecation (#7301) #7338

Open
wants to merge 1 commit into
base: release-v0.36.x
Choose a base branch
from

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Nov 6, 2024

Fixes #N/A

Description
Cherry-picks the changes from #7301

How was this change tested?
make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner November 6, 2024 21:50
@jmdeal jmdeal changed the title feat: invalidate SSM cache upon AMI deprecation (#7301) cp(v0.36.x): feat: invalidate SSM cache upon AMI deprecation (#7301) Nov 6, 2024
@coveralls
Copy link

coveralls commented Nov 6, 2024

Pull Request Test Coverage Report for Build 11714770567

Details

  • 124 of 153 (81.05%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 78.271%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/fake/ssmapi.go 26 27 96.3%
pkg/controllers/controllers.go 0 2 0.0%
pkg/providers/amifamily/ami.go 15 17 88.24%
pkg/apis/v1/ec2nodeclass.go 15 18 83.33%
pkg/operator/operator.go 0 5 0.0%
pkg/controllers/providers/ssm/invalidation/controller.go 34 40 85.0%
pkg/apis/v1/zz_generated.deepcopy.go 0 10 0.0%
Totals Coverage Status
Change from base Build 11713834679: -0.002%
Covered Lines: 5767
Relevant Lines: 7368

💛 - Coveralls

rschalo
rschalo previously approved these changes Nov 7, 2024
Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants