feat: add cpu sustained clock speed label to instance metadata #7043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for your contribution! Running the test workflows. |
Pull Request Test Coverage Report for Build 10949927017Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@aidan-canva are you able to fix the CI errors? |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
|
@njtran apologies for the delay, I've been on vacation for a period. I've just pushed a fix which should hopefully address the CI failures. Can I kick checks off myself? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some workloads are sensitive to variations instance CPU clock speed - either preferring a specific threshold or at least ensuring consistency across replicas. This PR adds the EC2
SustainedClockSpeedInGhzvalue as a Karpenter label (karpenter.k8s.aws/instance-cpu-sustained-clock-speed-mhz) so that workloads can add their preference.The upstream value from the EC2 API is in Ghz and represented as a float (ie 2.4). nodeSelectors only support ints or strings and most use-cases for this will want to leverage the
GtorLtoperators to set minimum/maximum values. To make this usable, this implementation converts the Ghz value into Mhz and represents it as an int.How was this change tested?
make testDoes this change impact docs?
Do codegen docs count?
website/content/en/preview/reference/instance-types.mdhas been updated to reflect this new instance attribute.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.