Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update deprecated label section #6490

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jigisha620
Copy link
Contributor

@jigisha620 jigisha620 commented Jul 11, 2024

Fixes #N/A

Description
Update docs for deprecated labels.These labels should only be used for persistent volumes.
#6440

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner July 11, 2024 00:57
@jigisha620 jigisha620 requested a review from jmdeal July 11, 2024 00:57
Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 916ba99
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/668f2ddf61c0910008954723
😎 Deploy Preview https://deploy-preview-6490--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jul 11, 2024

Pull Request Test Coverage Report for Build 12320385971

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.125%

Totals Coverage Status
Change from base Build 12320322681: 0.0%
Covered Lines: 5774
Relevant Lines: 8866

💛 - Coveralls

@@ -162,7 +162,7 @@ Take care to ensure the label domains are correct. A well known label like `karp
| karpenter.k8s.aws/instance-local-nvme | 900 | [AWS Specific] Number of gibibytes of local nvme storage on the instance |

{{% alert title="Note" color="primary" %}}
Karpenter translates the following deprecated labels to their stable equivalents: `failure-domain.beta.kubernetes.io/zone`, `failure-domain.beta.kubernetes.io/region`, `beta.kubernetes.io/arch`, `beta.kubernetes.io/os`, and `beta.kubernetes.io/instance-type`.
Deprecated labels such as: `failure-domain.beta.kubernetes.io/zone`, `failure-domain.beta.kubernetes.io/region`, `beta.kubernetes.io/arch`, `beta.kubernetes.io/os`, and `beta.kubernetes.io/instance-type` should only be used with persistent volumes. Karpenter will translate these deprecated labels to their stable equivalents.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not following why these should only be used with persistent volumes. Some of these are just artifacts of old versions of K8s. Reason for this change? I don't see any reference in the description

@jigisha620 jigisha620 marked this pull request as draft July 16, 2024 08:34
Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@jonathan-innis
Copy link
Contributor

Looks like we had intended to merge this in but it got closed-out by the stale-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants