Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add GHA linting #4933

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Oct 26, 2023

Fixes #N/A

Description

Add linting for GHA workflows
actionlint does not currently support composite action checking but this feature appears to be in the works (rhysd/actionlint#366). When that feature is implemented, we could also add that feature to our CI

How was this change tested?

actionlint -oneline

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner October 26, 2023 08:08
@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 0df41de
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/653c15a1f04a3500082db43f

@jonathan-innis jonathan-innis force-pushed the add-gha-linting branch 13 times, most recently from 48decff to 5b33162 Compare October 26, 2023 09:52
@jonathan-innis jonathan-innis marked this pull request as draft October 26, 2023 17:18
@jonathan-innis jonathan-innis force-pushed the add-gha-linting branch 9 times, most recently from b85fcb5 to 1f4454f Compare October 27, 2023 18:47
@jonathan-innis jonathan-innis marked this pull request as ready for review October 27, 2023 18:47
@jonathan-innis jonathan-innis force-pushed the add-gha-linting branch 3 times, most recently from 1e632a4 to 6423774 Compare October 27, 2023 19:05
@jonathan-innis jonathan-innis force-pushed the add-gha-linting branch 6 times, most recently from f508dd7 to 0635055 Compare October 27, 2023 19:43
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit ef3b625 into aws:main Oct 30, 2023
12 checks passed
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants