feat: Add full warnings list, dont ouput warning if disabled #1838
Conversation
|
@mrgrain is there someone that can review and move this pr along? |
There was a problem hiding this comment.
Thanks for the PR @Dzuelu ! Please start by describing the problem you are trying to resolve or the feature you are trying to add. Ideally this would be in a separate issue.
I think I have a vague idea of what it is you want to do, but it will help if you describe it.
|
@mrgrain any updates needed? Edit: Was too passive aggressive, you guys seem to have a ton of other projects to manage. Lmk if you need anything else from me. |
| if (enabledWarnings['metadata/missing-readme']) { | ||
| this._diagnostics.push(JsiiDiagnostic.JSII_0003_MISSING_README.createDetached()); | ||
| } |
There was a problem hiding this comment.
That's not really maintainable for us. So easy to forget this check. We should always emit these warning but then filter them at the point of printing.
|
@Dzuelu Sorry I missed you creating the issue. Thanks for that, it helped me understand. Did an initial review of the PR. I don't think the approach will be maintainable. Because it is too easy to forget adding the check. Instead we should always emit these warnings (like we currently do). And then we can filter them at the point of printing. |
Added full warning list w/ test for future warnings. Checked warning list before pushing diagnostic item.
Note:
jsii-directive/struct-on-non-interfacehad nothing using it from what I could tell.Fixes #2039
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.