-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add image builder dependency version tracker #2695
Conversation
/retest |
2 similar comments
/retest |
/retest |
7822fb3
to
68d144e
Compare
e13944b
to
fbbb436
Compare
/retest |
fbbb436
to
299a323
Compare
299a323
to
1467cc2
Compare
2da14f3
to
2758330
Compare
2758330
to
c85b672
Compare
/test all |
b90b344
to
53393d9
Compare
/test all |
1 similar comment
/test all |
/retest |
@jaxesn: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
53393d9
to
4deebdb
Compare
4deebdb
to
0ced2ab
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes:
We have had a number of users have trouble getting all the image-builder dependencies correct. I suspect this is due to users using the same admin machine across multiple versions of eks-a/image-builder. For example, in 0.18 we had to start requiring a newer ansible, which also requires python 3.9. If a user starts on a fresh machine, image builder will properly install packer/ansible/plugins for them and this is not an issue. However, say they had created an image with 0.17 which would have installed an older version of packer than 0.18 requires, well the image-builder ensure-packer script only looks for the executable, not the specific version.
The code changes here are simple. The target that image-builder cli calls (ex: local-build-nutanix-redhat-8) first calls
dep-<format>
which will run all the upstream scripts to install the deps and then runs our new script to actually ensure the versions match what we expect.This also adds a new target to the build_targets that will regenerate and compare this new yaml file so that when we bump image-builder git_tag we keep the yaml up to date with the proper versions.
I think in our world its better if we get strict here and error out (with a bypass) so that users arent spinning their wheels dealing with bad configurations.
This PR also adds output of the currently install tools for us to use when debugging with people, it looks like this:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.