Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tee to fix digest to tmpfile #2671

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Nov 17, 2023

Issue #, if available:

Description of changes:

I think I had originally changed this because for some reason tee itself does not work for me on my mac, or my linux instances. It appears that without using tee it does not work in codebuild.. not sure if its a difference in the helm version?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 17, 2023
@jaxesn jaxesn force-pushed the jgw/fix-push branch 2 times, most recently from d387b3f to 1a0efb1 Compare November 17, 2023 20:59
@jaxesn jaxesn changed the title wait for digest to exist after pushing helm chart use tee to fix digest to tmpfile Nov 17, 2023
Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit c423f80 into aws:main Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants