fix: add retries for flaky integ tests that depend on LLM responses#351
Merged
Hweinstock merged 1 commit intoaws:mainfrom Mar 17, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage ? 90.92%
=======================================
Files ? 43
Lines ? 4112
Branches ? 634
=======================================
Hits ? 3739
Misses ? 204
Partials ? 169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vivdalal
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Problem
Integration tests in
test_session_manager.pythat assert on LLM response content are inherently non-deterministic. A model might rephrase or omit expected keywords on any given run,causing spurious failures that erode CI trust.
Solution
Added
pytest-rerunfailuresas a dev dependency and gave each potentially flaky test up to 3 total attemptswith a 5-second cooldown. Only the non-deterministic tests are marked; all other tests remain strict single-pass.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.